Fix a couple of shape inference issues #5223
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Ganesan Ramalingam <[email protected]>
Signed-off-by: Ganesan Ramalingam <[email protected]>
Signed-off-by: Ganesan Ramalingam <[email protected]>
gramalingam
commented
May 12, 2023
Signed-off-by: Ganesan Ramalingam <[email protected]>
Signed-off-by: Ganesan Ramalingam <[email protected]>
Signed-off-by: Ganesan Ramalingam <[email protected]>
xadupre
reviewed
May 15, 2023
xadupre
approved these changes
May 16, 2023
q-ycong-p
pushed a commit
to q-ycong-p/onnx
that referenced
this pull request
May 18, 2023
Signed-off-by: Ganesan Ramalingam <[email protected]> Signed-off-by: Yu Cong <[email protected]>
adityagoel4512
pushed a commit
to adityagoel4512/onnx
that referenced
this pull request
Jul 28, 2023
Signed-off-by: Ganesan Ramalingam <[email protected]> Signed-off-by: Aditya Goel <[email protected]>
5 tasks
yuanyao-nv
pushed a commit
to yuanyao-nv/onnx
that referenced
this pull request
Aug 7, 2023
Signed-off-by: Ganesan Ramalingam <[email protected]>
yuanyao-nv
pushed a commit
to yuanyao-nv/onnx
that referenced
this pull request
Aug 7, 2023
Signed-off-by: Ganesan Ramalingam <[email protected]> Signed-off-by: Yuan Yao <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes a couple of issues revealed by Issue 5212.
(i) The data-propagation logic was not handling function-calls correctly. It was reusing the same map (for tracking values) in the caller and callee. We need to create a new map for the callee, and propagate values corresponding to the inputs (and outputs) to (and back from) the callee map.
(ii) Recently the proto definition was extended to specify default-values of attributes in FunctionProto. This extends the inference logic to account for it. (Note that the checker may require further extensions to handle this extension, that's to be done separately.)
(iii) Add test-cases to test the fixes.
Motivation and Context
Fixes a couple of issues revealed by Issue 5212