Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Conversation

@bddppq
Copy link
Contributor

@bddppq bddppq commented Mar 23, 2018

@bddppq bddppq requested a review from houseroad March 23, 2018 09:30
@bddppq
Copy link
Contributor Author

bddppq commented Mar 23, 2018

this is based on #650

@bddppq
Copy link
Contributor Author

bddppq commented Mar 23, 2018

this needs #652

@AppVeyorBot
Copy link

Build onnx 0.3.1807 failed (commit 7da35eddb2 by @bddppq)

@AppVeyorBot
Copy link

Build onnx 0.3.1815 completed (commit 3a7dec320e by @bddppq)

@bddppq
Copy link
Contributor Author

bddppq commented Mar 26, 2018

@houseroad Do you want to wait for other open PRs that are related to backend tests to be merged first?

@houseroad
Copy link
Member

@bddppq I think it's ok to merge this first. I will review later... Let me first unblock you :-)

@bddppq
Copy link
Contributor Author

bddppq commented Mar 26, 2018

@houseroad This one is not blocking me, feel free to make your choice :-)

@AppVeyorBot
Copy link

Build onnx 0.3.1859 failed (commit 4e09bec913 by @houseroad)

@AppVeyorBot
Copy link

Build onnx 0.3.1877 failed (commit 0cd0f9ffd6 by @bddppq)

@AppVeyorBot
Copy link

Build onnx 0.3.1886 failed (commit bdc3e9bf29 by @bddppq)

@AppVeyorBot
Copy link

Build onnx 0.3.1887 completed (commit bdc3e9bf29 by @bddppq)

Copy link
Member

@houseroad houseroad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for converting the node test data to simple models. :-)


from collections import namedtuple

TestCase = namedtuple('TestCase', [
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Probably add another two fields: atol, rtol for future use?

Also some comments to explain what the purpose of each field is?

Copy link
Contributor Author

@bddppq bddppq Mar 27, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

atol and rtol should be dealt in this PR #628

@houseroad houseroad merged commit 5716e20 into onnx:master Mar 27, 2018
@bddppq bddppq deleted the convert-node-testcases branch March 30, 2018 08:21
Ac2zoom pushed a commit to Ac2zoom/onnx that referenced this pull request Jun 21, 2018
* Convert all Node test cases to Model test cases

* Verionize model zoo with opset version

* regen

* lint

* Fix optimizer split pass for models with constant output

* regnerate test data

* Add back removed import
jcwchen pushed a commit to jcwchen/onnx that referenced this pull request Sep 23, 2020
* Convert all Node test cases to Model test cases

* Verionize model zoo with opset version

* regen

* lint

* Fix optimizer split pass for models with constant output

* regnerate test data

* Add back removed import
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants