-
Couldn't load subscription status.
- Fork 3.8k
Convert all Node tests to Model tests #651
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
this is based on #650 |
|
this needs #652 |
|
❌ Build onnx 0.3.1807 failed (commit 7da35eddb2 by @bddppq) |
|
✅ Build onnx 0.3.1815 completed (commit 3a7dec320e by @bddppq) |
|
@houseroad Do you want to wait for other open PRs that are related to backend tests to be merged first? |
|
@bddppq I think it's ok to merge this first. I will review later... Let me first unblock you :-) |
|
@houseroad This one is not blocking me, feel free to make your choice :-) |
|
❌ Build onnx 0.3.1859 failed (commit 4e09bec913 by @houseroad) |
|
❌ Build onnx 0.3.1877 failed (commit 0cd0f9ffd6 by @bddppq) |
|
❌ Build onnx 0.3.1886 failed (commit bdc3e9bf29 by @bddppq) |
|
✅ Build onnx 0.3.1887 completed (commit bdc3e9bf29 by @bddppq) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks for converting the node test data to simple models. :-)
|
|
||
| from collections import namedtuple | ||
|
|
||
| TestCase = namedtuple('TestCase', [ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Probably add another two fields: atol, rtol for future use?
Also some comments to explain what the purpose of each field is?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
atol and rtol should be dealt in this PR #628
* Convert all Node test cases to Model test cases * Verionize model zoo with opset version * regen * lint * Fix optimizer split pass for models with constant output * regnerate test data * Add back removed import
* Convert all Node test cases to Model test cases * Verionize model zoo with opset version * regen * lint * Fix optimizer split pass for models with constant output * regnerate test data * Add back removed import
#590