Update CMake to 3.24 and use LINK_LIBRARY:WHOLE_ARCHIVE #6934
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: cyy <[email protected]>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #6934 +/- ##
=======================================
Coverage 56.49% 56.49%
=======================================
Files 509 509
Lines 32724 32724
Branches 3097 3097
=======================================
Hits 18487 18487
Misses 13379 13379
Partials 858 858 ☔ View full report in Codecov by Sentry. |
xadupre
approved these changes
May 5, 2025
shethaadit
approved these changes
May 13, 2025
gramalingam
pushed a commit
to gramalingam/onnx
that referenced
this pull request
May 19, 2025
### Description <!-- - Describe your changes. --> This PR uses CMake 3.24 feature to simplify WHOLE_ARCHIVE handing. ### Motivation and Context Better tooling. <!-- - Why is this change required? What problem does it solve? --> <!-- - If it fixes an open issue, please link to the issue here. --> Signed-off-by: cyy <[email protected]> Signed-off-by: gramalingam <[email protected]>
geckosecurity
pushed a commit
to geckosecurity/onnx
that referenced
this pull request
May 29, 2025
### Description <!-- - Describe your changes. --> This PR uses CMake 3.24 feature to simplify WHOLE_ARCHIVE handing. ### Motivation and Context Better tooling. <!-- - Why is this change required? What problem does it solve? --> <!-- - If it fixes an open issue, please link to the issue here. --> Signed-off-by: cyy <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR uses CMake 3.24 feature to simplify WHOLE_ARCHIVE handing.
Motivation and Context
Better tooling.