Clarify that variable shadowing is not allowed #6955
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Justin Chu <[email protected]>
There was a problem hiding this comment.
Pull Request Overview
This PR updates the ONNX specification documentation to clarify that variable shadowing is not allowed in nested subgraphs.
- Clarifies that node output names, along with subgraph inputs and initializers, must be unique relative to names in outer scopes.
- Improves the documentation of single static assignment in nested subgraphs.
Codecov ReportAll modified and coverable lines are covered by tests ✅
✅ All tests successful. No failed tests found. Additional details and impacted files@@ Coverage Diff @@
## main #6955 +/- ##
=======================================
Coverage 56.49% 56.49%
=======================================
Files 509 509
Lines 32724 32724
Branches 3097 3097
=======================================
Hits 18487 18487
Misses 13379 13379
Partials 858 858 ☔ View full report in Codecov by Sentry. |
Co-authored-by: Copilot <[email protected]> Signed-off-by: Justin Chu <[email protected]>
There was a problem hiding this comment.
Pull Request Overview
This PR clarifies that variable shadowing is disallowed in nested subgraphs per the ONNX specification.
- Explicitly updates the documentation to state that node outputs, inputs, and initializers in nested subgraphs must not conflict with names in outer scopes.
- Addresses issue #2303.
shubhambhokare1
approved these changes
May 9, 2025
gramalingam
approved these changes
May 19, 2025
|
Sure! #6980 |
geckosecurity
pushed a commit
to geckosecurity/onnx
that referenced
this pull request
May 29, 2025
Clarify the ONNX spec and asserts that variable shadowing is not allowed in nested subgraphs. Fixes onnx#2303 --------- Signed-off-by: Justin Chu <[email protected]> Co-authored-by: Copilot <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Clarify the ONNX spec and asserts that variable shadowing is not allowed in nested subgraphs. Fixes #2303