Clarify default value for ratio input of Dropout operator
#7032
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Related to this, I found it odd that a dropout ratio of exactly 1.0 is disallowed. A value of 1.0 is perhaps not that useful as it discards all inputs, but is a legal value for a probability. |
|
Apologies, I've realized this is updating auto-generated docs rather than the source. Will fix. |
853fb86 to
58a7181
Compare
justinchuby
approved these changes
Jun 6, 2025
The docs for the `ratio` input for the Dropout operator had two conflicting sentences, one implying the default is zero and the other stating it is 0.5. The reference implementation and ONNX Runtime use 0.5. Signed-off-by: Robert Knight <[email protected]>
58a7181 to
01c5678
Compare
cyyever
approved these changes
Jun 7, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The docs for the
ratioinput of the Dropout operator had two conflicting sentences, one implying the default is zero and the other stating it is 0.5. The reference implementation and ONNX Runtime use 0.5, so take that as the correct value.