Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Conversation

@justinchuby
Copy link
Member

Fix #7054. Previously the input to Range was 1D when it should have been 0d.

@justinchuby justinchuby requested a review from gramalingam July 16, 2025 19:28
@justinchuby justinchuby added the topic: operator Issues related to ONNX operators label Jul 16, 2025
@justinchuby justinchuby requested a review from a team as a code owner July 16, 2025 19:28
@justinchuby justinchuby added the auto update doc Generate md/proto files automatically using the CI pipeline label Jul 16, 2025
@github-project-automation github-project-automation bot moved this to In progress in PR Tracker Jul 16, 2025
@codecov
Copy link

codecov bot commented Jul 16, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 53.64%. Comparing base (b9a3100) to head (605f6dc).
Report is 2 commits behind head on main.

✅ All tests successful. No failed tests found.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #7135   +/-   ##
=======================================
  Coverage   53.64%   53.64%           
=======================================
  Files         508      508           
  Lines       32174    32174           
  Branches     2970     2970           
=======================================
  Hits        17260    17260           
  Misses      14118    14118           
  Partials      796      796           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@justinchuby justinchuby added this to the 1.19 milestone Jul 16, 2025
@justinchuby
Copy link
Member Author

@onnx/sig-operators-approvers

@github-project-automation github-project-automation bot moved this from In progress to Reviewer approved in PR Tracker Jul 17, 2025
@justinchuby justinchuby merged commit 9825c60 into main Jul 17, 2025
39 checks passed
@justinchuby justinchuby deleted the justinchu/rms-def branch July 17, 2025 19:49
@github-project-automation github-project-automation bot moved this from Reviewer approved to Done in PR Tracker Jul 17, 2025
MagellaX pushed a commit to MagellaX/onnx that referenced this pull request Aug 9, 2025
Fix onnx#7054. Previously the input to
`Range` was 1D when it should have been 0d.

---------

Signed-off-by: Justin Chu <[email protected]>
Signed-off-by: Yash solanki <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

auto update doc Generate md/proto files automatically using the CI pipeline topic: bug fix topic: operator Issues related to ONNX operators

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

RMSNorm test models do not follow the op.Range spec

2 participants