Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Implement saturate_cast in numpy helper #7143

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Jul 22, 2025
Merged

Implement saturate_cast in numpy helper #7143

merged 4 commits into from
Jul 22, 2025

Conversation

@justinchuby
Copy link
Member

  • Rename saturating_cast to saturate_cast to match conventions in other frameworks.
  • Make the function work on all onnx supported dtypes.

@justinchuby
Implement saturate_cast
aa3afea 
Signed-off-by: Justin Chu <[email protected]>
@justinchuby justinchuby requested review from a team as code owners July 17, 2025 20:24
@github-project-automation github-project-automation bot moved this to In progress in PR Tracker Jul 17, 2025
@justinchuby justinchuby mentioned this pull request Jul 17, 2025
Merged
@justinchuby justinchuby added the module: utility Helper modules label Jul 17, 2025
@justinchuby justinchuby added this to the 1.19 milestone Jul 17, 2025
github-actions[bot]
github-actions bot reviewed Jul 17, 2025
View reviewed changes
Copy link
Contributor

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You can commit the suggested changes from lintrunner.

@justinchuby justinchuby added the auto update doc Generate md/proto files automatically using the CI pipeline label Jul 17, 2025
@justinchuby
format
dfde934 
Signed-off-by: Justin Chu <[email protected]>
@codecov
Copy link

codecov bot commented Jul 17, 2025 •
edited
Loading

Codecov Report

Attention: Patch coverage is 64.28571% with 5 lines in your changes missing coverage. Please review.

Project coverage is 53.64%. Comparing base (6769c41) to head (f37e403).
Report is 4 commits behind head on main.

✅ All tests successful. No failed tests found.

Files with missing lines Patch % Lines
onnx/numpy_helper.py 50.00% 2 Missing and 1 partial ⚠️
onnx/backend/test/case/node/cast.py 0.00% 1 Missing ⚠️
onnx/backend/test/case/node/castlike.py 0.00% 1 Missing ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #7143      +/-   ##
==========================================
- Coverage   53.64%   53.64%   -0.01%     
==========================================
  Files         508      508              
  Lines       32174    32177       +3     
  Branches     2970     2971       +1     
==========================================
  Hits        17260    17260              
- Misses      14118    14120       +2     
- Partials      796      797       +1

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@justinchuby @github-actions
CI:apply auto updated documentation/backend test data
1a11c8c 
Signed-off-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
@justinchuby justinchuby reopened this Jul 17, 2025
@github-project-automation github-project-automation bot moved this from In progress to Done in PR Tracker Jul 17, 2025
@github-project-automation github-project-automation bot moved this from Done to In progress in PR Tracker Jul 17, 2025
@justinchuby justinchuby enabled auto-merge (squash) July 17, 2025 20:37
@justinchuby justinchuby removed the auto update doc Generate md/proto files automatically using the CI pipeline label Jul 17, 2025
github-advanced-security[bot]
github-advanced-security bot found potential problems Jul 17, 2025
View reviewed changes
@justinchuby justinchuby changed the title Implement saturate_cast Implement saturate_cast in numpy helper Jul 17, 2025
@justinchuby
Update numpy_helper.py
f37e403 
Signed-off-by: Justin Chu <[email protected]>
xadupre
xadupre reviewed Jul 18, 2025
View reviewed changes
@justinchuby justinchuby merged commit 019d4d1 into main Jul 22, 2025
38 checks passed
@justinchuby justinchuby deleted the justinchu/saturate_cast branch July 22, 2025 08:00
@github-project-automation github-project-automation bot moved this from In progress to Done in PR Tracker Jul 22, 2025
alx256 pushed a commit to alx256/onnx that referenced this pull request Aug 1, 2025
@justinchuby @alx256
Implement saturate_cast (onnx#7143)
c81cc82 
- Rename saturating_cast to saturate_cast to match conventions in other
frameworks.
- Make the function work on all onnx supported dtypes.

---------

Signed-off-by: Justin Chu <[email protected]>
Signed-off-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: justinchuby <[email protected]>
Signed-off-by: Alexander Poulson <[email protected]>
@osalbahr osalbahr mentioned this pull request Aug 27, 2025
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@github-actions github-actions[bot] github-actions[bot] left review comments

@xadupre xadupre xadupre approved these changes

Assignees

No one assigned

Labels

module: utility Helper modules

Projects

PR Tracker
Status: Done

Milestone

1.19

Development

Successfully merging this pull request may close these issues.

2 participants

@justinchuby @xadupre