Fix Softmax reference for inputs of length 1 #7169
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Konstantin Pueckler <[email protected]>
justinchuby
approved these changes
Jul 24, 2025
justinchuby
approved these changes
Jul 24, 2025
Codecov ReportAll modified and coverable lines are covered by tests ✅
✅ All tests successful. No failed tests found. Additional details and impacted files@@ Coverage Diff @@
## main #7169 +/- ##
=======================================
Coverage 53.64% 53.64%
=======================================
Files 508 508
Lines 32177 32178 +1
Branches 2971 2971
=======================================
+ Hits 17260 17261 +1
Misses 14120 14120
Partials 797 797 ☔ View full report in Codecov by Sentry. |
alx256
pushed a commit
to alx256/onnx
that referenced
this pull request
Aug 1, 2025
### Description ``np.asarray`` ensures that an array is returned. This is necessary since ``np.exp`` returns a scalar when the input has length 1. ### Motivation and Context The problem arouse when testing onnx-reference via the https://github.com/cbourjau/onnx-tests tool. Signed-off-by: Konstantin Pueckler <[email protected]> Signed-off-by: Alexander Poulson <[email protected]>
MagellaX
pushed a commit
to MagellaX/onnx
that referenced
this pull request
Aug 9, 2025
### Description ``np.asarray`` ensures that an array is returned. This is necessary since ``np.exp`` returns a scalar when the input has length 1. ### Motivation and Context The problem arouse when testing onnx-reference via the https://github.com/cbourjau/onnx-tests tool. Signed-off-by: Konstantin Pueckler <[email protected]> Signed-off-by: Yash solanki <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
np.asarrayensures that an array is returned. This is necessary sincenp.expreturns a scalar when the input has length 1.Motivation and Context
The problem arouse when testing onnx-reference via the https://github.com/cbourjau/onnx-tests tool.