Add missing symbols for onnx-mlir #7179
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Sunny Anand <[email protected]>
justinchuby
reviewed
Jul 30, 2025
justinchuby
reviewed
Jul 30, 2025
justinchuby
reviewed
Jul 30, 2025
justinchuby
reviewed
Jul 30, 2025
Signed-off-by: Sunny Anand <[email protected]>
Signed-off-by: Sunny Anand <[email protected]>
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #7179 +/- ##
=======================================
Coverage 53.76% 53.76%
=======================================
Files 512 512
Lines 32198 32198
Branches 2944 2944
=======================================
Hits 17310 17310
Misses 14119 14119
Partials 769 769 ☔ View full report in Codecov by Sentry. |
Signed-off-by: Sunny Anand <[email protected]>
Signed-off-by: Sunny Anand <[email protected]>
…oducing the ONNX_API for private methods for backwards compatibility Signed-off-by: Sunny Anand <[email protected]>
Signed-off-by: Sunny Anand <[email protected]>
justinchuby
reviewed
Jul 31, 2025
justinchuby
reviewed
Jul 31, 2025
|
|
||
| template <typename T, typename... Args> | ||
| FunctionBuilder& AddAttributes(const std::string& attr_name, const T& attr_value, Args... args) { | ||
| ONNX_API FunctionBuilder& AddAttributes(const std::string& attr_name, const T& attr_value, Args... args) { |
Check notice
Code scanning / CodeQL
Unused static variable Note
alx256
pushed a commit
to alx256/onnx
that referenced
this pull request
Aug 1, 2025
### Description This pr tries to fix the fallout from the PR which changed the visibility of the functions/symbols: onnx#6393 ### Motivation and Context Fix onnx#7178 --------- Signed-off-by: Sunny Anand <[email protected]> Signed-off-by: Alexander Poulson <[email protected]>
MagellaX
pushed a commit
to MagellaX/onnx
that referenced
this pull request
Aug 9, 2025
### Description This pr tries to fix the fallout from the PR which changed the visibility of the functions/symbols: onnx#6393 ### Motivation and Context Fix onnx#7178 --------- Signed-off-by: Sunny Anand <[email protected]> Signed-off-by: Yash solanki <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This pr tries to fix the fallout from the PR which changed the visibility of the functions/symbols: #6393
Motivation and Context
Fix #7178