Clean up reference evaluator tests #7238
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Eetu Tunturi <[email protected]>
Signed-off-by: Eetu Tunturi <[email protected]>
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #7238 +/- ##
==========================================
+ Coverage 54.20% 54.33% +0.13%
==========================================
Files 511 511
Lines 31825 31819 -6
Branches 2848 2848
==========================================
+ Hits 17250 17290 +40
+ Misses 13805 13753 -52
- Partials 770 776 +6 ☔ View full report in Codecov by Sentry. |
andife
approved these changes
Aug 19, 2025
justinchuby
approved these changes
Aug 19, 2025
|
Thanks! |
xadupre
pushed a commit
to xadupre/onnx
that referenced
this pull request
Aug 31, 2025
### Description Clean up tests. Remove unnecessary skips and imports. ### Motivation and Context As per issue onnx#7098 there are unnecessary skips and imports in some tests. I found 17 tests that were marked as skipped a couple of years ago, now they pass without warnings. --------- Signed-off-by: Eetu Tunturi <[email protected]> Signed-off-by: xadupre <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Clean up tests. Remove unnecessary skips and imports.
Motivation and Context
As per issue #7098 there are unnecessary skips and imports in some tests. I found 17 tests that were marked as skipped a couple of years ago, now they pass without warnings.