Avoid unnecessary re-generating of proto files (#7253) #7306
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
### Description <!-- - Describe your changes. --> The CMake file is refined to avoid generating proto files at each build time. Before the change we used `add_custom_target` and the proto files were specified as by-produces. As a result, they were always generated each time CMake was executed. Now we use `add_custom_command` to explicitly specify these output files by its `OUTPUT` option, CMake can look at them and skip the command if they exist. ### Motivation and Context To make the builds more efficient and stable. <!-- - Why is this change required? What problem does it solve? --> <!-- - If it fixes an open issue, please link to the issue here. --> --------- Signed-off-by: cyy <[email protected]>
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## rel-1.19.1 #7306 +/- ##
=============================================
Coverage ? 53.76%
=============================================
Files ? 512
Lines ? 32199
Branches ? 2944
=============================================
Hits ? 17311
Misses ? 14119
Partials ? 769 ☔ View full report in Codecov by Sentry. |
titaiwangms
approved these changes
Sep 17, 2025
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: cyy [email protected]