@onsi sorry for bothering you, any issue with this PR? Regards

Hey @eloycoto just making sure I understand the PR in context. Are you doing something like CurrentGinkgoTestDescription in an AfterEach block, so you need the Duration to be consistently updating throughout the run?

Hi @williammartin

Yes! I need the current duration of the test in AfterEach.

Alright @eloycoto I'm on board with this functionality but I think there's a few things that need to be resolved around this PR.

Functionally, I think it is a problem that the runTime here will continue to increase after the test has finished when fetched via Summary(). See this test that could live in spec_test.go:

It("should have a runtime which remains consistent after spec run", func() {
	totalRunTime := summary.RunTime
	Ω(totalRunTime).Should(BeNumerically(">=", 10*time.Millisecond))

	Consistently(func() time.Duration { return spec.Summary("suite id").RunTime }).Should(Equal(totalRunTime))
})

I think this can be resolved by something as simple as:

runTime := spec.runTime
if runTime == 0 {
	runTime = time.Since(spec.startTime)
}

and then setting

RunTime:      runTime,

on the spec summary.

The other thing I think required here is a test for the behaviour you actually want, which is that:

It increases the runTime throughout the test execution

Because as far as I can see the only test that exists is post-execution. I think it would be fair for this test to live on the GinkgoCurrentTestDescription level, or the Summary level.

WDYT about these changes?

Thanks!

I'll work on this in the following days!

Hi @williammartin this should be ok to review ;-)

Sorry, It has been a busy week!

Alright, hopefully will get round to this shortly now Christmas is over :)

@williammartin Fixed ;-)

Cool. Thanks.