🐛 add enable-sync-labels flag to klusterlet operator #505
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #505 +/- ##
==========================================
+ Coverage 62.15% 62.17% +0.01%
==========================================
Files 140 140
Lines 11770 11760 -10
==========================================
- Hits 7316 7312 -4
+ Misses 3683 3675 -8
- Partials 771 773 +2
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
552bf46 to
035c8ea
Compare
Member
Author
Signed-off-by: Zhiwei Yin <[email protected]>
035c8ea to
bdeee2a
Compare
Member
|
/approve |
Contributor
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: qiujian16, zhiweiyin318 The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
zhiweiyin318
added a commit
to zhiweiyin318/ocm
that referenced
this pull request
Jun 13, 2024
…gement-io#505) Signed-off-by: Zhiwei Yin <[email protected]>
openshift-merge-bot bot
pushed a commit
that referenced
this pull request
Jun 13, 2024
* sync labels from klusterlet to all agent resources (#475) Signed-off-by: Zhiwei Yin <[email protected]> * add enable-sync-labels flag to klusterlet operator (#505) Signed-off-by: Zhiwei Yin <[email protected]> * fix issue that pull secret and ns are synced labels when enable-sync-labels is disabled (#511) Signed-off-by: Zhiwei Yin <[email protected]> --------- Signed-off-by: Zhiwei Yin <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
in gitops case, klusterlet is deployed by ArgoCD, so klusterlet has a label argocd.argoproj.io/instance=xxx. If everything created klusterlet inherits this label, these objects will be triggered as being managed by ArgoCD but actually they are not.
fix: to add a flag to enable sync labels feature, the default is disable.
Related issue(s)
Fixes #