✨ Miscellaneous code cleanup #881
Conversation
Signed-off-by: Alex <[email protected]>
|
Please review but don't merge yet |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #881 +/- ##
==========================================
- Coverage 63.73% 63.72% -0.01%
==========================================
Files 193 192 -1
Lines 18985 18922 -63
==========================================
- Hits 12100 12058 -42
+ Misses 5890 5871 -19
+ Partials 995 993 -2
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
| // initiate registration driver | ||
| var registerDriver register.RegisterDriver | ||
| if o.registrationOption.RegistrationAuth == AwsIrsaAuthType { | ||
| if o.registrationOption.RegistrationAuth == helpers.AwsIrsaAuthType { |
There was a problem hiding this comment.
I think we will need to move this to API repo finally.
There was a problem hiding this comment.
Could you please elaborate, what to move?
There was a problem hiding this comment.
AwsIrsaAuthType and CSRAuthType, we do not need to make it in this release.
There was a problem hiding this comment.
Ok thanks, does rest of the PR look to you? If yes, we can get it merged with mike's help tomorrow, after completing the testing.
mikeshng
left a comment
There was a problem hiding this comment.
Please review but don't merge yet
/hold
Please feel free to un-hold when you are ready.
|
/approve |
1c74eaa to
21a71d1
Compare
Signed-off-by: Gaurav Jaswal <[email protected]>
21a71d1 to
d096e8d
Compare
|
/unhold |
|
/assign @jaswalkiranavtar |
|
/lgtm |
|
@jaswalkiranavtar: you cannot LGTM your own PR. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
mikeshng
left a comment
There was a problem hiding this comment.
/lgtm
Thank you for your contributions!
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: jaswalkiranavtar, mikeshng, qiujian16 The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
57c78cd
into
open-cluster-management-io:main
Summary
Addressing miscellaneous code cleanup:
Related issue(s)
Ref: ##514