Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Feature/iss 1436 #1437

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
gaotongxiao merged 2 commits into from
Oct 10, 2022
Merged

Feature/iss 1436 #1437

gaotongxiao merged 2 commits into from
Oct 10, 2022

Conversation

@hsiehpinghan
Copy link

@hsiehpinghan hsiehpinghan commented Oct 10, 2022

Motivation

Let ResizeOCR full support mmcv.impad's pad_val parameters.

Modification

  1. ResizeOCR's img_pad_value parameter: "int" type -> "Number | Sequence[Number]" type

Checklist

Before PR:

  • I have read and followed the workflow indicated in the CONTRIBUTING.md to create this PR.
  • Pre-commit or linting tools indicated in CONTRIBUTING.md are used to fix the potential lint issues.
  • Bug fixes are covered by unit tests, the case that causes the bug should be added in the unit tests.
  • New functionalities are covered by complete unit tests. If not, please add more unit test to ensure the correctness.
  • The documentation has been modified accordingly, including docstring or example tutorials.

After PR:

  • If the modification has potential influence on downstream or other related projects, this PR should be tested with some of those projects.
  • CLA has been signed and all committers have signed the CLA in this PR.

@CLAassistant
Copy link

CLAassistant commented Oct 10, 2022 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

gaotongxiao
gaotongxiao approved these changes Oct 10, 2022
View reviewed changes
Copy link
Collaborator

@gaotongxiao gaotongxiao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks for your contribution!

@gaotongxiao gaotongxiao linked an issue Oct 10, 2022 that may be closed by this pull request
Let ResizeOCR cant set all mmcv.impad parameters. #1436
Closed
@gaotongxiao gaotongxiao merged commit a71889a into open-mmlab:main Oct 10, 2022
@OpenMMLab-Assistant005
Copy link

OpenMMLab-Assistant005 commented Apr 3, 2023

Hi @hsiehpinghan ！First of all, we want to express our gratitude for your significant PR in the MMOCR project. Your contribution is highly appreciated, and we are grateful for your efforts in helping improve this open-source project during your personal time. We believe that many developers will benefit from your PR.

We would also like to invite you to join our Special Interest Group (SIG) private channel on Discord, where you can share your experiences, ideas, and build connections with like-minded peers. To join the SIG channel, simply message moderator— OpenMMLab on Discord or briefly share your open-source contributions in the #introductions channel and we will assist you. Look forward to seeing you there! Join us ：https://discord.gg/raweFPmdzG

If you have WeChat account，welcome to join our community on WeChat. You can add our assistant ：openmmlabwx. Please add "mmsig + Github ID" as a remark when adding friends：）
Thank you again for your contribution❤

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@gaotongxiao gaotongxiao gaotongxiao approved these changes

Assignees

@gaotongxiao gaotongxiao

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Let ResizeOCR cant set all mmcv.impad parameters.

4 participants

@hsiehpinghan @CLAassistant @OpenMMLab-Assistant005 @gaotongxiao