Thanks to visit codestin.com
Credit goes to github.com

Skip to content

[Feature] add common typing #1596

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
gaotongxiao merged 1 commit into from
Dec 5, 2022
Merged

[Feature] add common typing #1596

gaotongxiao merged 1 commit into from
Dec 5, 2022

Conversation

@Harold-lkk
Copy link
Collaborator

@Harold-lkk Harold-lkk commented Dec 5, 2022

No description provided.

@Harold-lkk Harold-lkk marked this pull request as ready for review December 5, 2022 10:15
@codecov
Copy link

codecov bot commented Dec 5, 2022

Codecov Report

Base: 85.47% // Head: 85.64% // Increases project coverage by +0.17% 🎉

Coverage data is based on head (c1cc5a6) compared to base (782bcc4).
Patch coverage: 100.00% of modified lines in pull request are covered.

❗ Current head c1cc5a6 differs from pull request most recent head c06fa99. Consider uploading reports for the commit c06fa99 to get more accurate results

Additional details and impacted files 
@@             Coverage Diff             @@
##           dev-1.x    #1596      +/-   ##
===========================================
+ Coverage    85.47%   85.64%   +0.17%     
===========================================
  Files          162      162              
  Lines        10117    10123       +6     
  Branches      1392     1392              
===========================================
+ Hits          8647     8670      +23     
+ Misses        1221     1205      -16     
+ Partials       249      248       -1
Flag Coverage Δ
unittests 85.64% <100.00%> (+0.17%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
mmocr/utils/typing_utils.py 96.87% <100.00%> (+0.72%) ⬆️
...r/models/kie/postprocessors/sdmgr_postprocessor.py 91.17% <0.00%> (-1.48%) ⬇️
mmocr/utils/polygon_utils.py 97.40% <0.00%> (-1.30%) ⬇️
mmocr/datasets/transforms/textdet_transforms.py 91.53% <0.00%> (+1.32%) ⬆️
.../models/textdet/postprocessors/db_postprocessor.py 93.15% <0.00%> (+4.10%) ⬆️
...cr/models/textdet/module_losses/pan_module_loss.py 96.79% <0.00%> (+7.69%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@gaotongxiao gaotongxiao merged commit 08cab32 into open-mmlab:dev-1.x Dec 5, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@gaotongxiao gaotongxiao gaotongxiao approved these changes

Assignees

@gaotongxiao gaotongxiao

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@Harold-lkk @gaotongxiao