Thanks to visit codestin.com
Credit goes to github.com

Skip to content

[Feature] Add scheduler visualization from mmpretrain to mmocr #1866

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
gaotongxiao merged 6 commits into from
Apr 25, 2023
Merged

[Feature] Add scheduler visualization from mmpretrain to mmocr #1866

gaotongxiao merged 6 commits into from
Apr 25, 2023

Conversation

@A-new-b
Copy link
Contributor

@A-new-b A-new-b commented Apr 18, 2023 •
edited
Loading

Motivation

Transfer the scheduler visualization tool from mmpretrain to mmocr.

Modification

  1. create /tools/visualizations/vis_scheduler.py.
  2. move /tools/analysis_tools/browse_dataset.py to /tools/visualizations/browse_dataset.py.
  3. modify /docs/zh_cn/user_guides/useful_tools.md and /docs/en/user_guides/useful_tools.md for scheduler visualization tool.

Checklist

Before PR:

  • I have read and followed the workflow indicated in the CONTRIBUTING.md to create this PR.
  • Pre-commit or linting tools indicated in CONTRIBUTING.md are used to fix the potential lint issues.
  • Bug fixes are covered by unit tests, the case that causes the bug should be added in the unit tests.
  • New functionalities are covered by complete unit tests. If not, please add more unit test to ensure the correctness.
  • The documentation has been modified accordingly, including docstring or example tutorials.

After PR:

  • If the modification has potential influence on downstream or other related projects, this PR should be tested with some of those projects.
  • CLA has been signed and all committers have signed the CLA in this PR.

gaotongxiao
gaotongxiao reviewed Apr 25, 2023
View reviewed changes
@gaotongxiao
Copy link
Collaborator

gaotongxiao commented Apr 25, 2023

And the linting test seems not passed.

image

You can install pre-commit hooks to automatically fix this issue:

pip install -U pre-commit
pre-commit install
pre-commit run --all-files
git add --update
git commit

@A-new-b
Copy link
Contributor Author

A-new-b commented Apr 25, 2023 •
edited
Loading

And the linting test seems not passed.

image

You can install pre-commit hooks to automatically fix this issue:

pip install -U pre-commit
pre-commit install
pre-commit run --all-files
git add --update
git commit

I have fixed it

@A-new-b A-new-b requested a review from gaotongxiao April 25, 2023 10:13
gaotongxiao
gaotongxiao approved these changes Apr 25, 2023
View reviewed changes
Copy link
Collaborator

@gaotongxiao gaotongxiao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@gaotongxiao gaotongxiao merged commit 4eb3cc7 into open-mmlab:dev-1.x Apr 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@gaotongxiao gaotongxiao gaotongxiao approved these changes

Assignees

@gaotongxiao gaotongxiao

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@A-new-b @gaotongxiao