Thanks to visit codestin.com
Credit goes to github.com

Skip to content

fix a typo in csl_rotated_fcos_head #362

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
JinYuannn wants to merge 0 commits into from
Closed

fix a typo in csl_rotated_fcos_head #362

JinYuannn wants to merge 0 commits into from

Conversation

@JinYuannn
Copy link
Contributor

@JinYuannn JinYuannn commented Jun 16, 2022

fix a typo in csl_rotated_fcos_head, "seprate_angle" should be "separate_angle".

@yangxue0827 yangxue0827 requested a review from liuyanyi June 16, 2022 06:31
@yangxue0827 yangxue0827 changed the base branch from main to dev June 16, 2022 06:32
@codecov
Copy link

codecov bot commented Jun 16, 2022 •
edited
Loading

Codecov Report

Merging #362 (22f1632) into dev (22bbb49) will not change coverage.
The diff coverage is 0.00%.

@@           Coverage Diff           @@
##              dev     #362   +/-   ##
=======================================
  Coverage   30.86%   30.86%           
=======================================
  Files         119      119           
  Lines        7934     7934           
  Branches     1220     1220           
=======================================
  Hits         2449     2449           
  Misses       5384     5384           
  Partials      101      101
Flag Coverage Δ
unittests 30.84% <0.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
mmrotate/core/post_processing/bbox_nms_rotated.py 6.15% <0.00%> (ø)
...rotate/models/dense_heads/csl_rotated_fcos_head.py 13.88% <0.00%> (ø)
mmrotate/models/dense_heads/rotated_fcos_head.py 10.04% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 22bbb49...22f1632. Read the comment docs.

liuyanyi
liuyanyi approved these changes Jun 17, 2022
View reviewed changes
Copy link
Collaborator

@liuyanyi liuyanyi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@zytx121
Copy link
Collaborator

zytx121 commented Jun 20, 2022

Please pull down the latest dev branch by git pull upstream dev and push again.

yangxue0827
yangxue0827 approved these changes Jun 22, 2022
View reviewed changes
Copy link
Collaborator

@yangxue0827 yangxue0827 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@zytx121 zytx121 mentioned this pull request Jul 1, 2022
Closed
@ZwwWayne ZwwWayne changed the base branch from dev to main July 6, 2022 11:09
@ZwwWayne ZwwWayne changed the base branch from main to dev July 6, 2022 11:10
@ZwwWayne ZwwWayne changed the base branch from dev to main July 6, 2022 11:11
@yangxue0827
Copy link
Collaborator

yangxue0827 commented Jul 8, 2022

This branch has conflicts that must be resolved
@JinYuannn

@ZwwWayne ZwwWayne changed the base branch from main to dev August 1, 2022 01:56
@ZwwWayne ZwwWayne changed the base branch from dev to main August 1, 2022 01:56
@JinYuannn JinYuannn closed this Jan 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@liuyanyi liuyanyi liuyanyi approved these changes

@yangxue0827 yangxue0827 yangxue0827 approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@JinYuannn @zytx121 @yangxue0827 @liuyanyi