Thanks to visit codestin.com
Credit goes to github.com

Skip to content

feat: is_alloc for FieldArithmetic #105

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jul 1, 2024
Merged

feat: is_alloc for FieldArithmetic #105

merged 2 commits into from
Jul 1, 2024

Conversation

@cocohearts
Copy link
Contributor

@cocohearts cocohearts commented Jul 1, 2024

feat: 0-indexed is_allocated column for padding trace to power of 2, also pad dummy traces in testing, and adjust row indices where applicable

jonathanpwang
jonathanpwang reviewed Jul 1, 2024
View reviewed changes
Copy link
Contributor

@jonathanpwang jonathanpwang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you add some description what this PR does and why it's needed?
e.g., Is it hard to satisfy constraints with a dummy 0 row

@TlatoaniHJ TlatoaniHJ mentioned this pull request Jul 1, 2024
Merged
jonathanpwang
jonathanpwang requested changes Jul 1, 2024
View reviewed changes
Copy link
Contributor

@jonathanpwang jonathanpwang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

do you need to constrain is_alloc is a bit?

@TlatoaniHJ
Copy link
Contributor

TlatoaniHJ commented Jul 1, 2024

do you need to constrain is_alloc is a bit?

I think from the field arithmetic chip's perspective, as long as the arithmetic operations are correct then it's a valid trace, because we could view is_alloc as just representing the frequency with which that arithmetic operation was requested, and the frequency can be aribtrary. From that perspective maybe it makes sense to change the name to something involving frequency, rather than the current name that implies it's a boolean (though it is always boolean given the current trace generation).

@jonathanpwang
Copy link
Contributor

jonathanpwang commented Jul 1, 2024

do you need to constrain is_alloc is a bit?

I think from the field arithmetic chip's perspective, as long as the arithmetic operations are correct then it's a valid trace, because we could view is_alloc as just representing the frequency with which that arithmetic operation was requested, and the frequency can be aribtrary. From that perspective maybe it makes sense to change the name to something involving frequency, rather than the current name that implies it's a boolean (though it is always boolean given the current trace generation).

I agree

@jonathanpwang jonathanpwang merged commit d8ab17f into main Jul 1, 2024
@jonathanpwang jonathanpwang deleted the feat/field-arithmetic-alloc branch July 1, 2024 23:34
luffykai pushed a commit that referenced this pull request Dec 13, 2024
@cocohearts @jonathanpwang
feat: is_alloc for FieldArithmetic (#105)
dfc3fbb 
* feat: 0-indexed is_allocated column for padding trace to power of 2, also pad dummy traces in testing

* chore: rename `is_alloc` to `rcv_count`

---------

Co-authored-by: Alex Zhao <[email protected]>
Co-authored-by: Jonathan Wang <[email protected]>
jonathanpwang pushed a commit that referenced this pull request Aug 14, 2025
@matejav
feat: rv32im-mulh-tracegen + tests (#105)
e17cccc 
* wip: mulh tracegen

* feat: mulh tracegen + tests

* chore: small fix

* fix: minor import fixes from OpenVM

* fix: pass in tuple size by value

* fix: rangetuple

* test: remove rangetuple

* fix: initialize run to zero

* fix: pass in range tuple by value
jonathanpwang pushed a commit that referenced this pull request Aug 14, 2025
@matejav @jonathanpwang
feat: rv32im-mulh-tracegen + tests (#105)
780f675 
* wip: mulh tracegen

* feat: mulh tracegen + tests

* chore: small fix

* fix: minor import fixes from OpenVM

* fix: pass in tuple size by value

* fix: rangetuple

* test: remove rangetuple

* fix: initialize run to zero

* fix: pass in range tuple by value
jonathanpwang pushed a commit that referenced this pull request Aug 19, 2025
@matejav @jonathanpwang
feat: rv32im-mulh-tracegen + tests (#105)
2746a6f 
* wip: mulh tracegen

* feat: mulh tracegen + tests

* chore: small fix

* fix: minor import fixes from OpenVM

* fix: pass in tuple size by value

* fix: rangetuple

* test: remove rangetuple

* fix: initialize run to zero

* fix: pass in range tuple by value
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jonathanpwang jonathanpwang jonathanpwang approved these changes

@TlatoaniHJ TlatoaniHJ Awaiting requested review from TlatoaniHJ

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@cocohearts @TlatoaniHJ @jonathanpwang