Thanks to visit codestin.com
Credit goes to github.com

Skip to content

chore: add serde to segment #1749

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 17, 2025
Merged

chore: add serde to segment #1749

merged 1 commit into from
Jun 17, 2025

Conversation

@luffykai
Copy link
Contributor

@luffykai luffykai commented Jun 17, 2025

No description provided.

@luffykai luffykai requested a review from shuklaayush June 17, 2025 04:22
@codspeed-hq
Copy link

codspeed-hq bot commented Jun 17, 2025

CodSpeed Walltime Performance Report

Merging #1749 will not alter performance

Comparing lunkai/segment-serde (2f72f9f) with feat/new-execution (9364d65)

⚠️ Unknown Walltime execution environment detected

Using the Walltime instrument on standard Hosted Runners will lead to inconsistent data.

For the most accurate results, we recommend using CodSpeed Macro Runners: bare-metal machines fine-tuned for performance measurement consistency.

Summary

✅ 10 untouched benchmarks

@github-actions
Copy link

github-actions bot commented Jun 17, 2025

group app.proof_time_ms app.cycles app.cells_used leaf.proof_time_ms leaf.cycles leaf.cells_used
verify_fibair (-185 [-14.8%]) 1,066 322,773 17,341,042 - - -
fibonacci (-458 [-17.3%]) 2,197 1,500,277 50,589,503 - - -
regex (-1223 [-15.6%]) 6,633 4,165,432 166,519,456 - - -
ecrecover (+179 [+15.6%]) 1,327 (-14218 [-10.4%]) 122,000 (-548071 [-6.8%]) 7,542,191 - - -
pairing (+28 [+0.6%]) 4,494 1,862,964 (+230956 [+0.2%]) 97,508,739 - - -

Commit: 2f72f9f

Benchmark Workflow

@codspeed-hq
Copy link

codspeed-hq bot commented Jun 17, 2025

CodSpeed Instrumentation Performance Report

Merging #1749 will not alter performance

Comparing lunkai/segment-serde (2f72f9f) with feat/new-execution (9364d65)

Summary

✅ 10 untouched benchmarks

@jonathanpwang
Copy link
Contributor

jonathanpwang commented Jun 17, 2025

note: we may want to just write a custom serializer to bytes

@jonathanpwang jonathanpwang merged commit e8ded6c into feat/new-execution Jun 17, 2025
34 of 35 checks passed
@jonathanpwang jonathanpwang deleted the lunkai/segment-serde branch June 17, 2025 09:34
@jonathanpwang jonathanpwang mentioned this pull request Aug 19, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@shuklaayush shuklaayush shuklaayush approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@luffykai @jonathanpwang @shuklaayush