Thanks to visit codestin.com
Credit goes to github.com

Skip to content

fix(new-execution): add register contribtions on reset_segment #1843

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jul 10, 2025
Merged

fix(new-execution): add register contribtions on reset_segment #1843

merged 2 commits into from
Jul 10, 2025

Conversation

@shuklaayush
Copy link
Contributor

@shuklaayush shuklaayush commented Jul 10, 2025

for metering, we assume all registers are going to be read during execution and don't add their contributions in the hot loop.
this pr fixes the reset_segment function to also add the register contributions

@codspeed-hq
Copy link

codspeed-hq bot commented Jul 10, 2025 •
edited
Loading

CodSpeed WallTime Performance Report

Merging #1843 will not alter performance

Comparing fix/e2-reset-register-contributions (24179a2) with feat/new-execution (c4e2cb6)

⚠️ Unknown Walltime execution environment detected

Using the Walltime instrument on standard Hosted Runners will lead to inconsistent data.

For the most accurate results, we recommend using CodSpeed Macro Runners: bare-metal machines fine-tuned for performance measurement consistency.

Summary

✅ 20 untouched benchmarks

@github-actions

This comment has been minimized.

Sign in to view
stephenh-axiom-xyz
stephenh-axiom-xyz approved these changes Jul 10, 2025
View reviewed changes
Copy link
Contributor

@stephenh-axiom-xyz stephenh-axiom-xyz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@github-actions
Copy link

github-actions bot commented Jul 10, 2025

group app.proof_time_ms app.cycles app.cells_used leaf.proof_time_ms leaf.cycles leaf.cells_used
verify_fibair (-9 [-0.7%]) 1,244 322,700 17,271,202 - - -
fibonacci (+51 [+2.2%]) 2,414 1,500,277 50,589,231 - - -
regex (+58 [+0.8%]) 6,998 4,165,432 166,449,586 - - -
ecrecover (-35 [-2.5%]) 1,363 137,260 8,174,585 - - -
pairing (+11 [+0.3%]) 4,001 1,862,964 102,530,853 - - -

Commit: 24179a2

Benchmark Workflow

@jonathanpwang jonathanpwang merged commit dabf5d5 into feat/new-execution Jul 10, 2025
34 checks passed
@jonathanpwang jonathanpwang deleted the fix/e2-reset-register-contributions branch July 10, 2025 17:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jonathanpwang jonathanpwang jonathanpwang approved these changes

@stephenh-axiom-xyz stephenh-axiom-xyz stephenh-axiom-xyz approved these changes

@Golovanov399 Golovanov399 Awaiting requested review from Golovanov399

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@shuklaayush @jonathanpwang @stephenh-axiom-xyz