Thanks to visit codestin.com
Credit goes to github.com

Skip to content

chore: make plonky3 nightly-features optional #1818

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 3, 2025
Merged

chore: make plonky3 nightly-features optional #1818

merged 1 commit into from
Jul 3, 2025

Conversation

@jonathanpwang
Copy link
Contributor

@jonathanpwang jonathanpwang commented Jul 3, 2025

No description provided.

@jonathanpwang jonathanpwang requested a review from Qumeric July 3, 2025 19:50
@codspeed-hq
Copy link

codspeed-hq bot commented Jul 3, 2025

CodSpeed WallTime Performance Report

Merging #1818 will not alter performance

Comparing chore/make-nightlyfeat-opt (96a47ac) with feat/new-execution (3f2b5fc)

⚠️ Unknown Walltime execution environment detected

Using the Walltime instrument on standard Hosted Runners will lead to inconsistent data.

For the most accurate results, we recommend using CodSpeed Macro Runners: bare-metal machines fine-tuned for performance measurement consistency.

Summary

✅ 20 untouched benchmarks

@github-actions
Copy link

github-actions bot commented Jul 3, 2025

group app.proof_time_ms app.cycles app.cells_used leaf.proof_time_ms leaf.cycles leaf.cells_used
verify_fibair (-7 [-0.6%]) 1,255 322,699 17,271,190 - - -
fibonacci (+22 [+0.9%]) 2,356 1,500,277 50,589,231 - - -
regex (-75 [-1.1%]) 6,941 4,165,432 166,449,586 - - -
ecrecover (+6 [+0.4%]) 1,383 137,260 8,174,585 - - -
pairing (+21 [+0.5%]) 4,003 1,862,964 102,530,853 - - -

Commit: 96a47ac

Benchmark Workflow

@jonathanpwang
Copy link
Contributor Author

jonathanpwang commented Jul 3, 2025

comparison: https://github.com/axiom-crypto/openvm-reth-benchmark/actions/runs/16060591762

@jonathanpwang jonathanpwang merged commit 25ecd07 into feat/new-execution Jul 3, 2025
41 of 42 checks passed
@jonathanpwang jonathanpwang deleted the chore/make-nightlyfeat-opt branch July 3, 2025 21:59
Qumeric
Qumeric reviewed Jul 4, 2025
View reviewed changes
Copy link
Contributor

@Qumeric Qumeric left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jonathanpwang jonathanpwang mentioned this pull request Aug 19, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Qumeric Qumeric Qumeric left review comments

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@jonathanpwang @Qumeric