Thanks to visit codestin.com
Credit goes to github.com

Skip to content

fix(new-execution): revert "chore: update snark-verifier to v0.2.3 (#1938)" #1943

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Aug 7, 2025
Merged

fix(new-execution): revert "chore: update snark-verifier to v0.2.3 (#1938)" #1943

merged 1 commit into from
Aug 7, 2025

Conversation

@shuklaayush
Copy link
Contributor

@shuklaayush shuklaayush commented Aug 7, 2025

This reverts commit 22f1a5b.

@shuklaayush shuklaayush changed the title revert: "chore: update snark-verifier to v0.2.3 (#1938)" revert(new-execution): "chore: update snark-verifier to v0.2.3 (#1938)" Aug 7, 2025
@shuklaayush shuklaayush changed the title revert(new-execution): "chore: update snark-verifier to v0.2.3 (#1938)" fix(new-execution): revert "chore: update snark-verifier to v0.2.3 (#1938)" Aug 7, 2025
@shuklaayush shuklaayush merged commit 1f4eebd into feat/new-execution Aug 7, 2025
34 of 36 checks passed
@shuklaayush shuklaayush deleted the revert/new-exec-snark-verifier-bump branch August 7, 2025 16:21
@github-actions
Copy link

github-actions bot commented Aug 7, 2025

group app.proof_time_ms app.cycles app.cells_used leaf.proof_time_ms leaf.cycles leaf.cells_used
verify_fibair (-21 [-2.0%]) 1,010 322,700 18,750,324 - - -
fibonacci (+18 [+0.8%]) 2,146 3,000,420 51,504,507 - - -
regex (-12 [-0.2%]) 6,886 8,217,194 164,734,992 - - -
ecrecover (+16 [+1.4%]) 1,142 281,298 8,875,685 - - -
pairing (-28 [-0.8%]) 3,540 3,725,930 98,127,219 - - -

Commit: b1030ca

Benchmark Workflow

@codspeed-hq
Copy link

codspeed-hq bot commented Aug 7, 2025

CodSpeed WallTime Performance Report

Merging #1943 will not alter performance

Comparing revert/new-exec-snark-verifier-bump (b1030ca) with feat/new-execution (8a71af1)

⚠️ Unknown Walltime execution environment detected

Using the Walltime instrument on standard Hosted Runners will lead to inconsistent data.

For the most accurate results, we recommend using CodSpeed Macro Runners: bare-metal machines fine-tuned for performance measurement consistency.

Summary

✅ 27 untouched benchmarks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jonathanpwang jonathanpwang jonathanpwang approved these changes

@Qumeric Qumeric Awaiting requested review from Qumeric

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@shuklaayush @jonathanpwang