Thanks to visit codestin.com
Credit goes to github.com

Skip to content

feat(cli): add --verbose mode #1994

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Aug 18, 2025
Merged

feat(cli): add --verbose mode #1994

merged 2 commits into from
Aug 18, 2025

Conversation

@jonathanpwang
Copy link
Contributor

@jonathanpwang jonathanpwang commented Aug 18, 2025 •
edited
Loading

closes INT-4790

usage:

cargo openvm --verbose keygen
cargo openvm --verbose prove app

@jonathanpwang jonathanpwang requested a review from yi-sun August 18, 2025 16:00
@github-actions

This comment has been minimized.

Sign in to view
@codspeed-hq
Copy link

codspeed-hq bot commented Aug 18, 2025 •
edited
Loading

CodSpeed WallTime Performance Report

Merging #1994 will improve performances by 14.28%

Comparing cli/verbose-mode (197b444) with feat/new-execution (74a0760)

⚠️ Unknown Walltime execution environment detected

Using the Walltime instrument on standard Hosted Runners will lead to inconsistent data.

For the most accurate results, we recommend using CodSpeed Macro Runners: bare-metal machines fine-tuned for performance measurement consistency.

Summary

⚡ 1 improvements
✅ 26 untouched benchmarks

Benchmarks breakdown

Benchmark BASE HEAD Change
⚡ benchmark_execute[factorial_iterative_u256] 184.9 ms 161.8 ms +14.28%

@github-actions
Copy link

github-actions bot commented Aug 18, 2025

group app.proof_time_ms app.cycles app.cells_used leaf.proof_time_ms leaf.cycles leaf.cells_used
verify_fibair (+19 [+0.9%]) 2,131 322,700 18,750,324 - - -
fibonacci (+13 [+0.6%]) 2,326 1,500,210 51,504,507 - - -
regex (-45 [-0.6%]) 7,663 4,108,597 164,734,992 - - -
ecrecover (-20 [-1.4%]) 1,378 140,487 8,866,654 - - -
pairing (+121 [+3.1%]) 4,055 1,882,939 98,834,293 - - -

Commit: 197b444

Benchmark Workflow

yi-sun
yi-sun approved these changes Aug 18, 2025
View reviewed changes
Copy link
Collaborator

@yi-sun yi-sun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@yi-sun yi-sun changed the title feat(cli): --verbose mode feat(cli): add --verbose mode Aug 18, 2025
@jonathanpwang jonathanpwang merged commit 4db999b into feat/new-execution Aug 18, 2025
37 of 38 checks passed
@jonathanpwang jonathanpwang deleted the cli/verbose-mode branch August 18, 2025 16:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@yi-sun yi-sun yi-sun approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@jonathanpwang @yi-sun