Thanks to visit codestin.com
Credit goes to github.com

Skip to content

docs(changelog): document change in vk binary format #1998

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Aug 18, 2025
Merged

docs(changelog): document change in vk binary format #1998

merged 1 commit into from
Aug 18, 2025

Conversation

@jonathanpwang
Copy link
Contributor

@jonathanpwang jonathanpwang commented Aug 18, 2025

No description provided.

@github-actions
Copy link

github-actions bot commented Aug 18, 2025

group app.proof_time_ms app.cycles app.cells_used leaf.proof_time_ms leaf.cycles leaf.cells_used
verify_fibair (+19 [+0.9%]) 2,109 322,700 18,750,324 - - -
fibonacci (+21 [+0.9%]) 2,339 1,500,210 51,504,507 - - -
regex (-41 [-0.5%]) 7,614 4,108,597 164,734,992 - - -
ecrecover (-56 [-3.8%]) 1,400 140,487 8,866,654 - - -
pairing (-37 [-0.9%]) 3,899 1,882,939 98,834,293 - - -

Commit: ea8b58b

Benchmark Workflow

@codspeed-hq
Copy link

codspeed-hq bot commented Aug 18, 2025

CodSpeed WallTime Performance Report

Merging #1998 will degrade performances by 10.57%

Comparing docs/vk-bin-change (ea8b58b) with feat/new-execution (4db999b)

⚠️ Unknown Walltime execution environment detected

Using the Walltime instrument on standard Hosted Runners will lead to inconsistent data.

For the most accurate results, we recommend using CodSpeed Macro Runners: bare-metal machines fine-tuned for performance measurement consistency.

Summary

❌ 1 regressions
✅ 26 untouched benchmarks

⚠️ Please fix the performance issues or acknowledge them on CodSpeed.

Benchmarks breakdown

Benchmark BASE HEAD Change
❌ benchmark_execute_metered[revm_snailtracer] 16.4 ms 18.3 ms -10.57%

@jonathanpwang jonathanpwang merged commit 30221fb into feat/new-execution Aug 18, 2025
35 checks passed
@jonathanpwang jonathanpwang deleted the docs/vk-bin-change branch August 18, 2025 20:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@jonathanpwang