Thanks to visit codestin.com
Credit goes to github.com

Skip to content

fix(new-execution): replace segmentation strategy with segmentation limits #1901

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Jul 25, 2025
Merged

fix(new-execution): replace segmentation strategy with segmentation limits #1901

merged 4 commits into from
Jul 25, 2025

Conversation

@shuklaayush
Copy link
Contributor

@shuklaayush shuklaayush commented Jul 25, 2025

Resolves INT-4316

@shuklaayush shuklaayush force-pushed the fix/new-exec-remove-seg-strategy branch from 1ccf98f to bb76cc8 Compare July 25, 2025 13:22
@github-actions

This comment has been minimized.

Sign in to view
@codspeed-hq
Copy link

codspeed-hq bot commented Jul 25, 2025 •
edited
Loading

CodSpeed WallTime Performance Report

Merging #1901 will degrade performances by 11.17%

Comparing fix/new-exec-remove-seg-strategy (926dea4) with feat/new-execution (a35aa57)

⚠️ Unknown Walltime execution environment detected

Using the Walltime instrument on standard Hosted Runners will lead to inconsistent data.

For the most accurate results, we recommend using CodSpeed Macro Runners: bare-metal machines fine-tuned for performance measurement consistency.

Summary

⚡ 2 improvements
❌ 1 regressions
✅ 21 untouched benchmarks

⚠️ Please fix the performance issues or acknowledge them on CodSpeed.

Benchmarks breakdown

Benchmark BASE HEAD Change
⚡ benchmark_execute[bubblesort] 39.3 ms 34.1 ms +15.4%
⚡ benchmark_execute[factorial_iterative_u256] 171.9 ms 155.1 ms +10.8%
❌ benchmark_execute[fibonacci_recursive] 67.3 ms 75.8 ms -11.17%

@github-actions

This comment has been minimized.

Sign in to view
jonathanpwang
jonathanpwang reviewed Jul 25, 2025
View reviewed changes
jonathanpwang
jonathanpwang reviewed Jul 25, 2025
View reviewed changes
jonathanpwang
jonathanpwang approved these changes Jul 25, 2025
View reviewed changes
Copy link
Contributor

@jonathanpwang jonathanpwang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@github-actions
Copy link

github-actions bot commented Jul 25, 2025

group app.proof_time_ms app.cycles app.cells_used leaf.proof_time_ms leaf.cycles leaf.cells_used
verify_fibair (-2 [-0.2%]) 1,075 322,649 17,671,796 - - -
fibonacci (+17 [+0.8%]) 2,233 3,000,556 51,508,517 - - -
regex (-22 [-0.3%]) 7,534 8,330,866 165,431,684 - - -
ecrecover (-16 [-1.4%]) 1,106 274,568 8,596,011 - - -
pairing (+20 [+0.6%]) 3,655 3,725,930 93,105,233 - - -

Commit: 926dea4

Benchmark Workflow

@shuklaayush shuklaayush merged commit 198eb39 into feat/new-execution Jul 25, 2025
34 checks passed
@shuklaayush shuklaayush deleted the fix/new-exec-remove-seg-strategy branch July 25, 2025 15:15
@shuklaayush shuklaayush mentioned this pull request Jul 25, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jonathanpwang jonathanpwang jonathanpwang approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@shuklaayush @jonathanpwang