feat: flat hash page read #59
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jonathanpwang
requested changes
Jun 28, 2024
Contributor
jonathanpwang
left a comment
There was a problem hiding this comment.
Overall setup looks right. Left some comments to be addressed, which I think was mostly because you were still ramping up on some AIR stuff back then.
It would be better if this AIR could handle pages that had height not a power of 2 (not fully allocated), but I think we can address that later.
You will likely want to update this and repurpose it for INT-1681 soon anyways, so we can leave future improvements for that ticket.
added 2 commits
July 3, 2024 14:35
…lic imports etc. need fixes
added 22 commits
July 12, 2024 11:25
2e1c17f to
2580e44
Compare
Contributor
|
Test is failing |
Contributor
|
@cocohearts you can rebase and use #137 to debug |
Contributor
Author
|
just fixed, sorry missed this |
jonathanpwang
approved these changes
Jul 15, 2024
luffykai
pushed a commit
that referenced
this pull request
Dec 13, 2024
* dummy hash * chore: fixed dummy hash * chore: clean up dummy-hash * removing generics for sizing * feat: receive, sends, request() * basic structure completed, debugging * refactor complete, debugging NonZeroCumulativeSum * fixed hashchip receive, added one each positive and negative test * chore: subchip initialization/trace generation * changed to using the hash_chip of flathashchip * chore: rename DummyHashChip to DummyHashAir * feat: requests to dummyhashchip, positive test case works * cleaned positive test, added negative test * feat: receive for flathash * feat: negative test spoofs every element in flathash trace * chore: clean code * feat: multiplicity for hashchip to support arbitrarily many hash receives * chore: update test * chore: code cleanup * chore: code cleanup * feat: fixed tests * docs(FlatHashAir) * chore: replaces pis/request with DummyHashAir::hash(), clean code * feat: arbitrary page height (padding to power of 2) --------- Co-authored-by: Alex Zhao <[email protected]>
jonathanpwang
pushed a commit
that referenced
this pull request
Aug 14, 2025
jonathanpwang
pushed a commit
that referenced
this pull request
Aug 14, 2025
jonathanpwang
pushed a commit
that referenced
this pull request
Aug 19, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Spec: https://docs.google.com/document/d/1Y9_oTyuGqJTw3Wa7MWDBlaqxUsCsVD1cED4z_b1pjkU/edit#heading=h.gmb22k5m4h56