[feat] Query binary: predicate #85
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
jonathanpwang
requested changes
Jun 27, 2024
Contributor
jonathanpwang
left a comment
There was a problem hiding this comment.
Logic looks good, but needs to split out into keygen, prove, verify functions
Contributor
Contributor
Author
|
@jonathanpwang ready for review: addressed comments and added prover trace data inputs (failing test is in vm folder) |
jonathanpwang
requested changes
Jun 30, 2024
Contributor
jonathanpwang
left a comment
There was a problem hiding this comment.
Requesting some small changes
Contributor
Author
|
@jonathanpwang addressed comments |
jonathanpwang
approved these changes
Jul 1, 2024
luffykai
pushed a commit
that referenced
this pull request
Dec 13, 2024
* Predicate binary branched off main * Merge in main changes * Move common data to folder * Split out keygen, prove, and verify * Use cached traces * Remove -v, -t, and -d flags from common * Require input trace
Avaneesh-axiom
pushed a commit
that referenced
this pull request
Jan 10, 2025
* Predicate binary branched off main * Merge in main changes * Move common data to folder * Split out keygen, prove, and verify * Use cached traces * Remove -v, -t, and -d flags from common * Require input trace
jonathanpwang
added a commit
that referenced
this pull request
Mar 9, 2025
**Finding Link:** https://cantina.xyz/code/c486d600-bed0-4fc6-aed1-de759fd29fa2/findings/11 ## Description of Fix The LogUp linear equalities on trace heights together with a new condition that we require VM instruction executor chips to satisfy ensures that the timestamp does not overflow the field. We then range check the final timestamp in the Connector Chip. We state the new condition in the circuit spec (circuit.md) together with an inspection of all existing chips to justify that they satisfy the condition. --------- Co-authored-by: Jonathan Wang <[email protected]>
jonathanpwang
added a commit
that referenced
this pull request
Mar 9, 2025
**Finding Link:** https://cantina.xyz/code/c486d600-bed0-4fc6-aed1-de759fd29fa2/findings/11 ## Description of Fix The LogUp linear equalities on trace heights together with a new condition that we require VM instruction executor chips to satisfy ensures that the timestamp does not overflow the field. We then range check the final timestamp in the Connector Chip. We state the new condition in the circuit spec (circuit.md) together with an inspection of all existing chips to justify that they satisfy the condition. --------- Co-authored-by: Jonathan Wang <[email protected]>
jonathanpwang
pushed a commit
that referenced
this pull request
Aug 14, 2025
jonathanpwang
pushed a commit
that referenced
this pull request
Aug 14, 2025
jonathanpwang
pushed a commit
that referenced
this pull request
Aug 19, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
bin/predicate/README.mdfor instructions.Full test
Run from the root of the repository.
# config.toml [page] index_bytes = 32 data_bytes = 32 bits_per_fe = 16 height = 256Benchmark