rar2john: Distinguish unexpected EOF from other errors #5862
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Check for feof() before parsing errno. Similar fixes should probably be made to a lot of other files throughout our tree. See openwall#5860
solardiz
approved these changes
Oct 10, 2025
We were printing the error but then chugged along producing a b0rken hash that would be uncrackable.
Check for feof() before parsing errno. Similar fixes should probably be made to a lot of other files throughout our tree. See openwall#5860
|
Added same fixes for keepass2john as well. I expected to find more problems but I only searched for |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Check for feof() before parsing errno. Similar fixes should probably be made to a lot of other files throughout our tree.
See #5860