fixes #2505 adds central configuration with events #2792
+1,225
−11
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
andrewpmartinez
commented
Feb 12, 2025
- uses dynamic JSON protobuf struct marshalling to avoid having to declare every setting in protobuf
- uses dynamic JSON protobuf struct marshalling to avoid having to declare every setting in protobuf
plorenz
reviewed
Feb 14, 2025
| store.settingControllerListeners[setting][id] = append(store.settingControllerListeners[setting][id], listener) | ||
| } | ||
| } | ||
|
|
There was a problem hiding this comment.
Not clear why you're deleting the listener if the controller specific settings are removed. Isn't the listener still going to want to react to changes to the global config?
plorenz
reviewed
Feb 14, 2025
| type controllerSettingStoreImpl struct { | ||
| *baseStore[*ControllerSetting] | ||
| indexName boltz.ReadIndex | ||
| symbolEnrollments boltz.EntitySetSymbol |
There was a problem hiding this comment.
The map is likely being accessed/mutated across goroutines, should probably be protected
plorenz
reviewed
Feb 14, 2025
| func (ae *AppEnv) GetPeerSigners() []*x509.Certificate { | ||
| return ae.HostController.GetPeerSigners() | ||
| } | ||
|
|
There was a problem hiding this comment.
We already have GetId(). That's return the token id from the cert, AFAIK, so this should hopefully not be needed.
plorenz
reviewed
Feb 14, 2025
| if err != nil { | ||
| return nil, fmt.Errorf("could not marshal entity: %w", err) | ||
| } | ||
|
|
There was a problem hiding this comment.
I'm doing some json in protobuf as well for inspect stuff. I'll look at this and see if it makes sense to use there.
plorenz
reviewed
Feb 14, 2025
| "github.com/openziti/ziti/controller/models" | ||
| "go.etcd.io/bbolt" | ||
| ) | ||
|
|
plorenz
requested changes
Feb 14, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.