feat: expose import / export features in the API #3012
+227
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thank you very much for this PR. We are not ready to add this functionality to the controller at this time, which is why the CLI does the heavy lifting for now. Additionally, it creates a dependency on the Edge API from the Fabric API. The Edge API is currently not required for some bare-bones configurations of the controller. The Edge and Fabric have been slowly merging, but at this point, this type of dependency isn't something we can accept. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR exposes the import / export CLI features in the edge management API for use by ZAC.
This PR depends on openziti/edge-api#150.
Closes #3013.