Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Improvements for Power Supplies #961

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 47 commits into from
Mar 29, 2025
Merged

Improvements for Power Supplies #961

merged 47 commits into from
Mar 29, 2025

Conversation

@cesarBLG
Copy link
Contributor

@cesarBLG cesarBLG commented Jun 28, 2024 •
edited
Loading

Includes some features by @Sharpe49:

  • Voltage, pantograph and power limitation selectors
  • Support for INI parameter files
  • Refactoring of power supplies
  • Minor variable additions for scripts

Additionally:

  • Power limitation for traction and dynamic braking
  • Default implementations for selectors
  • Generic buttons for power supply scripts
  • Customizable minimum RPM as required by train supply
  • Backup dynamic brake for neutral sections
  • Minor fixes
  • Variable additions for scripts

This is a huge PR, probably the best way to review it is commit by commit (there are also a lot though)

@cesarBLG cesarBLG added not-for-unstable Special label to exclude a pull request from the Unstable Version enhancement New feature or request labels Jun 28, 2024
@cesarBLG cesarBLG force-pushed the powersupply-scripts branch from 0242713 to 207f1bc Compare July 6, 2024 10:37
@peternewell
Copy link
Contributor

peternewell commented Jul 7, 2024

Whilst you are working on this module, could you also review the power requirements for the Unpowered Control Car?

Some power operations should be able to be controlled from it as well.

Thanks

@cesarBLG
Copy link
Contributor Author

cesarBLG commented Jul 7, 2024

Sure, I'll look at it

@cjakeman
Copy link
Contributor

cjakeman commented Aug 31, 2024

Hi Cesar,

Would you be able to add a link to a Blueprint or a Trello card for this PR?

Also, is it ready to be included in the Unstable Version yet?

Thanks,

Chris

@SteelFill
Copy link
Contributor

SteelFill commented Sep 5, 2024

Scanned through all the commits and it certainly looks like a very useful set of features for those using the power supply scripts. Don't use those myself so I am not in a position to judge the functionality, but it all at least looks to be consistent with the existing functionality.

@cesarBLG
Copy link
Contributor Author

cesarBLG commented Sep 11, 2024

Hi Chris,

I was on holidays, but I'll add a blueprint/card as soon as possible.

Only documentation is missing before I can mark it as 'ready for review'. It was also low priority for me because this PR conflicts with a previous one (I don't remember which), so it couldn't be merged at the time I created it.

I'm working on this very slowly, and my intention was not to create the PR until it was fully ready, but I created it since it contained a bugfix. Eventually I created a separate PR for the bug and kept this as a draft due to the merge conflict.

@cesarBLG cesarBLG mentioned this pull request Sep 23, 2024
Merged
@Sharpe49
Copy link
Contributor

Sharpe49 commented Sep 25, 2024 •
edited
Loading

To answer about the scriptable selector, yes it makes sense, because sometimes, you have to code interlockings between selectors which are specific to a type of train.
For example, for the TGV, the voltage selector can only be turned if the pantograph is selected down by the driver.
On other trains, you may not even need to lower the pantograph to change voltage (for example, on the Citadis Dualis).
Example : https://github.com/Sharpe49/OpenRails_Scripts/blob/master/common.script/SNCFVoltageSelector.cs

@cesarBLG
Copy link
Contributor Author

cesarBLG commented Sep 25, 2024

Hi Cédric, thanks for your comment.

My reason for removing the scripting features is that I thought that the interlocking could be implemented centrally at the PowerSupply script. That is, you intercept the related events there, and if conditions are not met you don't propagate the event to the related controller. The motivation was that more information is available from the PowerSupply class, so you can have a richer condition set for the interlocking.

However, I can revert 90f2542 if you prefer so, I don't have a strong opinion against scripting the controllers.

@Sharpe49
Copy link
Contributor

Sharpe49 commented Sep 25, 2024

I don't like the idea to do the interlocking in the PowerSupply class. First, that would mean it will be done differently than the brake controller (a class for the controller, and other classes for the system). Secondly, it will pollute the code of the PowerSupply. It has already many things to do, let's not add things which can be separated in a class. We must not put everything in the same box, that would be a mess in the long run.

@cesarBLG cesarBLG added for-unstable Special label to include a pull request in the Unstable Version and removed not-for-unstable Special label to exclude a pull request from the Unstable Version labels Oct 24, 2024
@cesarBLG cesarBLG marked this pull request as ready for review October 24, 2024 09:19
twpol pushed a commit that referenced this pull request Oct 24, 2024
@openrails-bot
Automatic merge of T1.5.1-1321-g597ce24c42 and 16 pull requests
47963c4 
- Pull request #961 at 89854d3: Improvements for Power Supplies
- Pull request #839 at d00beb9: First phase of https://blueprints.launchpad.net/or/+spec/additional-cruise-control-parameters
- Pull request #891 at 9a1d6b2: Auto save
- Pull request #892 at 1f5ba4c: Signal Function OPP_SIG_ID_TRAINPATH
- Pull request #953 at a519452: Fix Lights Crash on Corrupt Shapes
- Pull request #972 at e90a2aa: On Map window color changed switch or signal is not changed
- Pull request #981 at 10d297f: Multiple type trainset lightglows
- Pull request #984 at 0f8122e: Player train switching for timetable mode
- Pull request #988 at f1d4d18: Conditional sound, blueprint https://blueprints.launchpad.net/or/+spec/conditional-sound
- Pull request #989 at 32a9961: Fix: TrainCarOperations-crashes-locales
- Pull request #990 at 37d8ea6: Fix TrainDrivingInfo, some texts are misaligned.
- Pull request #991 at 220b61e: Fix TrainCarOperations no interacts AltPgDn AltPgUp.
- Pull request #994 at 1de8de6: 2 fixes in the OR manual
- Pull request #900 at c27f32d: DMI updates
- Pull request #876 at f92de76: docs: add source for documents previously on website to source Documentation folder
- Pull request #995 at 992191c: Fix: TrainCarOperations and TrainOperationsViewer windows overlap.
@cesarBLG
Copy link
Contributor Author

cesarBLG commented Oct 24, 2024

Hi @cjakeman,
I finally found some time to update the docs, I'm removing the draft condition. I registered a new blueprint https://blueprints.launchpad.net/or/+spec/power-supply-scripting-enhancements . This also covers some other feature requests that I indicated in the first message.

@cesarBLG cesarBLG force-pushed the powersupply-scripts branch from 89854d3 to 9ae470f Compare October 24, 2024 14:41
twpol pushed a commit that referenced this pull request Oct 24, 2024
@openrails-bot
Automatic merge of T1.5.1-1321-g597ce24c42 and 16 pull requests
09a8cdc 
- Pull request #961 at 9ae470f: Improvements for Power Supplies
- Pull request #839 at d00beb9: First phase of https://blueprints.launchpad.net/or/+spec/additional-cruise-control-parameters
- Pull request #891 at 9a1d6b2: Auto save
- Pull request #892 at 1f5ba4c: Signal Function OPP_SIG_ID_TRAINPATH
- Pull request #953 at a519452: Fix Lights Crash on Corrupt Shapes
- Pull request #972 at e90a2aa: On Map window color changed switch or signal is not changed
- Pull request #981 at 10d297f: Multiple type trainset lightglows
- Pull request #984 at 0f8122e: Player train switching for timetable mode
- Pull request #988 at f1d4d18: Conditional sound, blueprint https://blueprints.launchpad.net/or/+spec/conditional-sound
- Pull request #989 at 32a9961: Fix: TrainCarOperations-crashes-locales
- Pull request #990 at 37d8ea6: Fix TrainDrivingInfo, some texts are misaligned.
- Pull request #991 at 220b61e: Fix TrainCarOperations no interacts AltPgDn AltPgUp.
- Pull request #994 at 1de8de6: 2 fixes in the OR manual
- Pull request #900 at c27f32d: DMI updates
- Pull request #876 at f92de76: docs: add source for documents previously on website to source Documentation folder
- Pull request #995 at 992191c: Fix: TrainCarOperations and TrainOperationsViewer windows overlap.
twpol pushed a commit that referenced this pull request Oct 25, 2024
@openrails-bot
Automatic merge of T1.5.1-1321-g597ce24c42 and 17 pull requests
0771605 
- Pull request #961 at 9ae470f: Improvements for Power Supplies
- Pull request #839 at d00beb9: First phase of https://blueprints.launchpad.net/or/+spec/additional-cruise-control-parameters
- Pull request #891 at 9a1d6b2: Auto save
- Pull request #892 at 1f5ba4c: Signal Function OPP_SIG_ID_TRAINPATH
- Pull request #953 at a519452: Fix Lights Crash on Corrupt Shapes
- Pull request #972 at e90a2aa: On Map window color changed switch or signal is not changed
- Pull request #981 at 10d297f: Multiple type trainset lightglows
- Pull request #984 at 0f8122e: Player train switching for timetable mode
- Pull request #988 at f1d4d18: Conditional sound, blueprint https://blueprints.launchpad.net/or/+spec/conditional-sound
- Pull request #989 at 32a9961: Fix: TrainCarOperations-crashes-locales
- Pull request #990 at 37d8ea6: Fix TrainDrivingInfo, some texts are misaligned.
- Pull request #991 at 220b61e: Fix TrainCarOperations no interacts AltPgDn AltPgUp.
- Pull request #994 at 1de8de6: 2 fixes in the OR manual
- Pull request #996 at 2ccefab: Replace dynamic brakes by engine brakes at low speeds
- Pull request #900 at c27f32d: DMI updates
- Pull request #876 at f92de76: docs: add source for documents previously on website to source Documentation folder
- Pull request #995 at 992191c: Fix: TrainCarOperations and TrainOperationsViewer windows overlap.
twpol pushed a commit that referenced this pull request Oct 27, 2024
@openrails-bot
Automatic merge of T1.5.1-1321-g597ce24c42 and 18 pull requests
f49d492 
- Pull request #961 at 9ae470f: Improvements for Power Supplies
- Pull request #839 at d00beb9: First phase of https://blueprints.launchpad.net/or/+spec/additional-cruise-control-parameters
- Pull request #891 at 9a1d6b2: Auto save
- Pull request #892 at 1f5ba4c: Signal Function OPP_SIG_ID_TRAINPATH
- Pull request #953 at a519452: Fix Lights Crash on Corrupt Shapes
- Pull request #972 at e90a2aa: On Map window color changed switch or signal is not changed
- Pull request #981 at 10d297f: Multiple type trainset lightglows
- Pull request #984 at 0f8122e: Player train switching for timetable mode
- Pull request #988 at f1d4d18: Conditional sound, blueprint https://blueprints.launchpad.net/or/+spec/conditional-sound
- Pull request #989 at 32a9961: Fix: TrainCarOperations-crashes-locales
- Pull request #990 at 37d8ea6: Fix TrainDrivingInfo, some texts are misaligned.
- Pull request #991 at 220b61e: Fix TrainCarOperations no interacts AltPgDn AltPgUp.
- Pull request #994 at 1de8de6: 2 fixes in the OR manual
- Pull request #996 at 2ccefab: Replace dynamic brakes by engine brakes at low speeds
- Pull request #997 at 0de38ec: Disable independent brake syncing by default
- Pull request #900 at c27f32d: DMI updates
- Pull request #876 at f92de76: docs: add source for documents previously on website to source Documentation folder
- Pull request #995 at 992191c: Fix: TrainCarOperations and TrainOperationsViewer windows overlap.
twpol pushed a commit that referenced this pull request Oct 27, 2024
@openrails-bot
Automatic merge of T1.5.1-1321-g597ce24c42 and 18 pull requests
f8d6148 
- Pull request #961 at 36520e6: Improvements for Power Supplies
- Pull request #839 at d00beb9: First phase of https://blueprints.launchpad.net/or/+spec/additional-cruise-control-parameters
- Pull request #891 at 9a1d6b2: Auto save
- Pull request #892 at 1f5ba4c: Signal Function OPP_SIG_ID_TRAINPATH
- Pull request #953 at a519452: Fix Lights Crash on Corrupt Shapes
- Pull request #972 at e90a2aa: On Map window color changed switch or signal is not changed
- Pull request #981 at 10d297f: Multiple type trainset lightglows
- Pull request #984 at 0f8122e: Player train switching for timetable mode
- Pull request #988 at f1d4d18: Conditional sound, blueprint https://blueprints.launchpad.net/or/+spec/conditional-sound
- Pull request #989 at 32a9961: Fix: TrainCarOperations-crashes-locales
- Pull request #990 at 37d8ea6: Fix TrainDrivingInfo, some texts are misaligned.
- Pull request #991 at 220b61e: Fix TrainCarOperations no interacts AltPgDn AltPgUp.
- Pull request #994 at 1de8de6: 2 fixes in the OR manual
- Pull request #996 at 2ccefab: Replace dynamic brakes by engine brakes at low speeds
- Pull request #997 at 0de38ec: Disable independent brake syncing by default
- Pull request #900 at c27f32d: DMI updates
- Pull request #876 at f92de76: docs: add source for documents previously on website to source Documentation folder
- Pull request #995 at 992191c: Fix: TrainCarOperations and TrainOperationsViewer windows overlap.
@cesarBLG cesarBLG force-pushed the powersupply-scripts branch from 36520e6 to b3c717e Compare October 27, 2024 18:59
twpol pushed a commit that referenced this pull request Oct 27, 2024
@openrails-bot
Automatic merge of T1.5.1-1321-g597ce24c42 and 18 pull requests
9c37cf9 
- Pull request #961 at b3c717e: Improvements for Power Supplies
- Pull request #839 at d00beb9: First phase of https://blueprints.launchpad.net/or/+spec/additional-cruise-control-parameters
- Pull request #891 at 9a1d6b2: Auto save
- Pull request #892 at 1f5ba4c: Signal Function OPP_SIG_ID_TRAINPATH
- Pull request #953 at a519452: Fix Lights Crash on Corrupt Shapes
- Pull request #972 at e90a2aa: On Map window color changed switch or signal is not changed
- Pull request #981 at 10d297f: Multiple type trainset lightglows
- Pull request #984 at 0f8122e: Player train switching for timetable mode
- Pull request #988 at f1d4d18: Conditional sound, blueprint https://blueprints.launchpad.net/or/+spec/conditional-sound
- Pull request #989 at 32a9961: Fix: TrainCarOperations-crashes-locales
- Pull request #990 at 37d8ea6: Fix TrainDrivingInfo, some texts are misaligned.
- Pull request #991 at 220b61e: Fix TrainCarOperations no interacts AltPgDn AltPgUp.
- Pull request #994 at 1de8de6: 2 fixes in the OR manual
- Pull request #996 at 2ccefab: Replace dynamic brakes by engine brakes at low speeds
- Pull request #997 at 0de38ec: Disable independent brake syncing by default
- Pull request #900 at c27f32d: DMI updates
- Pull request #876 at f92de76: docs: add source for documents previously on website to source Documentation folder
- Pull request #995 at 992191c: Fix: TrainCarOperations and TrainOperationsViewer windows overlap.
twpol pushed a commit that referenced this pull request Oct 27, 2024
@openrails-bot
Automatic merge of T1.5.1-1321-g597ce24c42 and 18 pull requests
bc63f0a 
- Pull request #961 at b3c717e: Improvements for Power Supplies
- Pull request #839 at d00beb9: First phase of https://blueprints.launchpad.net/or/+spec/additional-cruise-control-parameters
- Pull request #891 at 9a1d6b2: Auto save
- Pull request #892 at 1f5ba4c: Signal Function OPP_SIG_ID_TRAINPATH
- Pull request #953 at a519452: Fix Lights Crash on Corrupt Shapes
- Pull request #972 at e90a2aa: On Map window color changed switch or signal is not changed
- Pull request #981 at 10d297f: Multiple type trainset lightglows
- Pull request #984 at 0f8122e: Player train switching for timetable mode
- Pull request #988 at f1d4d18: Conditional sound, blueprint https://blueprints.launchpad.net/or/+spec/conditional-sound
- Pull request #989 at 32a9961: Fix: TrainCarOperations-crashes-locales
- Pull request #990 at 37d8ea6: Fix TrainDrivingInfo, some texts are misaligned.
- Pull request #991 at 220b61e: Fix TrainCarOperations no interacts AltPgDn AltPgUp.
- Pull request #994 at 1de8de6: 2 fixes in the OR manual
- Pull request #996 at 7d9eda4: Replace dynamic brakes by engine brakes at low speeds
- Pull request #997 at 0de38ec: Disable independent brake syncing by default
- Pull request #900 at c27f32d: DMI updates
- Pull request #876 at f92de76: docs: add source for documents previously on website to source Documentation folder
- Pull request #995 at 992191c: Fix: TrainCarOperations and TrainOperationsViewer windows overlap.
twpol pushed a commit that referenced this pull request Oct 27, 2024
@openrails-bot
Automatic merge of T1.5.1-1321-g597ce24c42 and 18 pull requests
f1ef07d 
- Pull request #961 at b3c717e: Improvements for Power Supplies
- Pull request #839 at d00beb9: First phase of https://blueprints.launchpad.net/or/+spec/additional-cruise-control-parameters
- Pull request #891 at 9a1d6b2: Auto save
- Pull request #892 at 1f5ba4c: Signal Function OPP_SIG_ID_TRAINPATH
- Pull request #953 at a519452: Fix Lights Crash on Corrupt Shapes
- Pull request #972 at e90a2aa: On Map window color changed switch or signal is not changed
- Pull request #981 at 10d297f: Multiple type trainset lightglows
- Pull request #984 at 0f8122e: Player train switching for timetable mode
- Pull request #988 at f1d4d18: Conditional sound, blueprint https://blueprints.launchpad.net/or/+spec/conditional-sound
- Pull request #989 at 32a9961: Fix: TrainCarOperations-crashes-locales
- Pull request #990 at 37d8ea6: Fix TrainDrivingInfo, some texts are misaligned.
- Pull request #991 at 220b61e: Fix TrainCarOperations no interacts AltPgDn AltPgUp.
- Pull request #994 at 1de8de6: 2 fixes in the OR manual
- Pull request #996 at 2fcbcde: Replace dynamic brakes by engine brakes at low speeds
- Pull request #997 at 0de38ec: Disable independent brake syncing by default
- Pull request #900 at c27f32d: DMI updates
- Pull request #876 at f92de76: docs: add source for documents previously on website to source Documentation folder
- Pull request #995 at 992191c: Fix: TrainCarOperations and TrainOperationsViewer windows overlap.
@cesarBLG cesarBLG force-pushed the powersupply-scripts branch from b3c717e to 478bc23 Compare October 28, 2024 08:18
twpol pushed a commit that referenced this pull request Oct 28, 2024
@openrails-bot
Automatic merge of T1.5.1-1321-g597ce24c42 and 18 pull requests
79907c4 
- Pull request #961 at 478bc23: Improvements for Power Supplies
- Pull request #839 at d00beb9: First phase of https://blueprints.launchpad.net/or/+spec/additional-cruise-control-parameters
- Pull request #891 at 9a1d6b2: Auto save
- Pull request #892 at 1f5ba4c: Signal Function OPP_SIG_ID_TRAINPATH
- Pull request #953 at a519452: Fix Lights Crash on Corrupt Shapes
- Pull request #972 at e90a2aa: On Map window color changed switch or signal is not changed
- Pull request #981 at 10d297f: Multiple type trainset lightglows
- Pull request #984 at 0f8122e: Player train switching for timetable mode
- Pull request #988 at f1d4d18: Conditional sound, blueprint https://blueprints.launchpad.net/or/+spec/conditional-sound
- Pull request #989 at 32a9961: Fix: TrainCarOperations-crashes-locales
- Pull request #990 at 37d8ea6: Fix TrainDrivingInfo, some texts are misaligned.
- Pull request #991 at 220b61e: Fix TrainCarOperations no interacts AltPgDn AltPgUp.
- Pull request #994 at 1de8de6: 2 fixes in the OR manual
- Pull request #996 at 2fcbcde: Replace dynamic brakes by engine brakes at low speeds
- Pull request #997 at 0de38ec: Disable independent brake syncing by default
- Pull request #900 at c27f32d: DMI updates
- Pull request #876 at f92de76: docs: add source for documents previously on website to source Documentation folder
- Pull request #995 at 992191c: Fix: TrainCarOperations and TrainOperationsViewer windows overlap.
twpol pushed a commit that referenced this pull request Mar 13, 2025
@openrails-bot
Automatic merge of T1.5.1-1598-gb2a8053e3 and 12 pull requests
b6f59cd 
- Pull request #900 at b54024b: DMI in 3D cab + two more dials
- Pull request #1057 at 5ae14bc: Switchable brake system
- Pull request #892 at 1f5ba4c: Signal Function OPP_SIG_ID_TRAINPATH
- Pull request #961 at 4148bea: Improvements for Power Supplies
- Pull request #1026 at 6a89a97: Fix for Multiplayer: remote trains chuff can't be heard https://bugs.launchpad.net/or/+bug/2092771
- Pull request #1029 at 31fd7d2: Superelevation Follow Up Fixes
- Pull request #1031 at 34aa23a: Multiplayer Server, forked from Open Rails Ultimate; blueprint https://blueprints.launchpad.net/or/+spec/multiplayer-server
- Pull request #1033 at 7efd355: Multiple signal light textures per signal
- Pull request #1047 at b7152dc: Docs: adds translation docs
- Pull request #1051 at 0ac5d30: Mouse wheel support for cabview controls + refactor
- Pull request #1056 at 27ebc35: Check for null BrakemanBrakeController
- Pull request #896 at f1681df: First implementation of https://blueprints.launchpad.net/or/+spec/specific-sounds-for-ai-trains
twpol pushed a commit that referenced this pull request Mar 13, 2025
@openrails-bot
Automatic merge of T1.5.1-1600-gee9c56d91 and 11 pull requests
c8f7863 
- Pull request #900 at b54024b: DMI in 3D cab + two more dials
- Pull request #1057 at 60d5d63: Switchable brake system
- Pull request #892 at 1f5ba4c: Signal Function OPP_SIG_ID_TRAINPATH
- Pull request #961 at 4148bea: Improvements for Power Supplies
- Pull request #1026 at 6a89a97: Fix for Multiplayer: remote trains chuff can't be heard https://bugs.launchpad.net/or/+bug/2092771
- Pull request #1029 at 31fd7d2: Superelevation Follow Up Fixes
- Pull request #1031 at 34aa23a: Multiplayer Server, forked from Open Rails Ultimate; blueprint https://blueprints.launchpad.net/or/+spec/multiplayer-server
- Pull request #1033 at 7efd355: Multiple signal light textures per signal
- Pull request #1047 at b7152dc: Docs: adds translation docs
- Pull request #1051 at 0ac5d30: Mouse wheel support for cabview controls + refactor
- Pull request #896 at f1681df: First implementation of https://blueprints.launchpad.net/or/+spec/specific-sounds-for-ai-trains
twpol pushed a commit that referenced this pull request Mar 14, 2025
@openrails-bot
Automatic merge of T1.5.1-1600-gee9c56d91 and 12 pull requests
aef9b46 
- Pull request #900 at b54024b: DMI in 3D cab + two more dials
- Pull request #892 at 1f5ba4c: Signal Function OPP_SIG_ID_TRAINPATH
- Pull request #961 at 4148bea: Improvements for Power Supplies
- Pull request #1015 at 14c132b: Enhancements for EP brakes
- Pull request #1026 at 6a89a97: Fix for Multiplayer: remote trains chuff can't be heard https://bugs.launchpad.net/or/+bug/2092771
- Pull request #1029 at 31fd7d2: Superelevation Follow Up Fixes
- Pull request #1031 at 34aa23a: Multiplayer Server, forked from Open Rails Ultimate; blueprint https://blueprints.launchpad.net/or/+spec/multiplayer-server
- Pull request #1033 at 7efd355: Multiple signal light textures per signal
- Pull request #1047 at b7152dc: Docs: adds translation docs
- Pull request #1051 at 0ac5d30: Mouse wheel support for cabview controls + refactor
- Pull request #1055 at d1a56b3: Route Based TTrack Sounds
- Pull request #896 at f1681df: First implementation of https://blueprints.launchpad.net/or/+spec/specific-sounds-for-ai-trains
twpol pushed a commit that referenced this pull request Mar 15, 2025
@openrails-bot
Automatic merge of T1.5.1-1600-gee9c56d91 and 13 pull requests
a3c0b63 
- Pull request #900 at b54024b: DMI in 3D cab + two more dials
- Pull request #892 at 1f5ba4c: Signal Function OPP_SIG_ID_TRAINPATH
- Pull request #961 at 4148bea: Improvements for Power Supplies
- Pull request #1015 at 14c132b: Enhancements for EP brakes
- Pull request #1026 at 6a89a97: Fix for Multiplayer: remote trains chuff can't be heard https://bugs.launchpad.net/or/+bug/2092771
- Pull request #1029 at 31fd7d2: Superelevation Follow Up Fixes
- Pull request #1031 at 34aa23a: Multiplayer Server, forked from Open Rails Ultimate; blueprint https://blueprints.launchpad.net/or/+spec/multiplayer-server
- Pull request #1033 at 7efd355: Multiple signal light textures per signal
- Pull request #1047 at b7152dc: Docs: adds translation docs
- Pull request #1051 at 0ac5d30: Mouse wheel support for cabview controls + refactor
- Pull request #1058 at 626ebed: Refactor notification parameters
- Pull request #1055 at d1a56b3: Route Based TTrack Sounds
- Pull request #896 at f1681df: First implementation of https://blueprints.launchpad.net/or/+spec/specific-sounds-for-ai-trains
twpol pushed a commit that referenced this pull request Mar 15, 2025
@openrails-bot
Automatic merge of T1.5.1-1600-gee9c56d91 and 13 pull requests
950e1d0 
- Pull request #900 at b54024b: DMI in 3D cab + two more dials
- Pull request #892 at 1f5ba4c: Signal Function OPP_SIG_ID_TRAINPATH
- Pull request #961 at ffccb2e: Improvements for Power Supplies
- Pull request #1015 at 14c132b: Enhancements for EP brakes
- Pull request #1026 at 6a89a97: Fix for Multiplayer: remote trains chuff can't be heard https://bugs.launchpad.net/or/+bug/2092771
- Pull request #1029 at 31fd7d2: Superelevation Follow Up Fixes
- Pull request #1031 at 34aa23a: Multiplayer Server, forked from Open Rails Ultimate; blueprint https://blueprints.launchpad.net/or/+spec/multiplayer-server
- Pull request #1033 at 7efd355: Multiple signal light textures per signal
- Pull request #1047 at b7152dc: Docs: adds translation docs
- Pull request #1051 at 0ac5d30: Mouse wheel support for cabview controls + refactor
- Pull request #1058 at 626ebed: Refactor notification parameters
- Pull request #1055 at d1a56b3: Route Based TTrack Sounds
- Pull request #896 at f1681df: First implementation of https://blueprints.launchpad.net/or/+spec/specific-sounds-for-ai-trains
twpol pushed a commit that referenced this pull request Mar 15, 2025
@openrails-bot
Automatic merge of T1.5.1-1603-gb8c8c9a48 and 12 pull requests
35582ce 
- Pull request #900 at b54024b: DMI in 3D cab + two more dials
- Pull request #892 at 1f5ba4c: Signal Function OPP_SIG_ID_TRAINPATH
- Pull request #961 at ffccb2e: Improvements for Power Supplies
- Pull request #1015 at 14c132b: Enhancements for EP brakes
- Pull request #1026 at 6a89a97: Fix for Multiplayer: remote trains chuff can't be heard https://bugs.launchpad.net/or/+bug/2092771
- Pull request #1029 at 31fd7d2: Superelevation Follow Up Fixes
- Pull request #1031 at 34aa23a: Multiplayer Server, forked from Open Rails Ultimate; blueprint https://blueprints.launchpad.net/or/+spec/multiplayer-server
- Pull request #1047 at eb8027b: Docs: adds translation docs
- Pull request #1051 at 0ac5d30: Mouse wheel support for cabview controls + refactor
- Pull request #1058 at 626ebed: Refactor notification parameters
- Pull request #1055 at d1a56b3: Route Based TTrack Sounds
- Pull request #896 at f1681df: First implementation of https://blueprints.launchpad.net/or/+spec/specific-sounds-for-ai-trains
twpol pushed a commit that referenced this pull request Mar 15, 2025
@openrails-bot
Automatic merge of T1.5.1-1606-gf9e80b97d and 11 pull requests
3e68613 
- Pull request #900 at b54024b: DMI in 3D cab + two more dials
- Pull request #892 at 1f5ba4c: Signal Function OPP_SIG_ID_TRAINPATH
- Pull request #961 at ffccb2e: Improvements for Power Supplies
- Pull request #1015 at 14c132b: Enhancements for EP brakes
- Pull request #1026 at 6a89a97: Fix for Multiplayer: remote trains chuff can't be heard https://bugs.launchpad.net/or/+bug/2092771
- Pull request #1029 at 31fd7d2: Superelevation Follow Up Fixes
- Pull request #1031 at 34aa23a: Multiplayer Server, forked from Open Rails Ultimate; blueprint https://blueprints.launchpad.net/or/+spec/multiplayer-server
- Pull request #1047 at eb8027b: Docs: adds translation docs
- Pull request #1058 at 626ebed: Refactor notification parameters
- Pull request #1055 at d1a56b3: Route Based TTrack Sounds
- Pull request #896 at f1681df: First implementation of https://blueprints.launchpad.net/or/+spec/specific-sounds-for-ai-trains
@cesarBLG cesarBLG requested a review from pzgulyas March 15, 2025 12:59
twpol pushed a commit that referenced this pull request Mar 15, 2025
@openrails-bot
Automatic merge of T1.5.1-1606-gf9e80b97d and 11 pull requests
5d5faa2 
- Pull request #900 at b54024b: DMI in 3D cab + two more dials
- Pull request #892 at 1f5ba4c: Signal Function OPP_SIG_ID_TRAINPATH
- Pull request #961 at ffccb2e: Improvements for Power Supplies
- Pull request #1015 at 1ade99e: Enhancements for EP brakes
- Pull request #1026 at 6a89a97: Fix for Multiplayer: remote trains chuff can't be heard https://bugs.launchpad.net/or/+bug/2092771
- Pull request #1029 at 31fd7d2: Superelevation Follow Up Fixes
- Pull request #1031 at 34aa23a: Multiplayer Server, forked from Open Rails Ultimate; blueprint https://blueprints.launchpad.net/or/+spec/multiplayer-server
- Pull request #1047 at eb8027b: Docs: adds translation docs
- Pull request #1058 at 626ebed: Refactor notification parameters
- Pull request #1055 at d1a56b3: Route Based TTrack Sounds
- Pull request #896 at f1681df: First implementation of https://blueprints.launchpad.net/or/+spec/specific-sounds-for-ai-trains
twpol pushed a commit that referenced this pull request Mar 15, 2025
@openrails-bot
Automatic merge of T1.5.1-1608-g273f2ef97 and 11 pull requests
a96900c 
- Pull request #900 at b54024b: DMI in 3D cab + two more dials
- Pull request #1030 at c279fd8: Refactor settings, in prep for settings exporter
- Pull request #892 at 1f5ba4c: Signal Function OPP_SIG_ID_TRAINPATH
- Pull request #961 at ffccb2e: Improvements for Power Supplies
- Pull request #1015 at 1ade99e: Enhancements for EP brakes
- Pull request #1029 at 31fd7d2: Superelevation Follow Up Fixes
- Pull request #1031 at 34aa23a: Multiplayer Server, forked from Open Rails Ultimate; blueprint https://blueprints.launchpad.net/or/+spec/multiplayer-server
- Pull request #1047 at eb8027b: Docs: adds translation docs
- Pull request #1058 at 626ebed: Refactor notification parameters
- Pull request #1055 at d1a56b3: Route Based TTrack Sounds
- Pull request #896 at f1681df: First implementation of https://blueprints.launchpad.net/or/+spec/specific-sounds-for-ai-trains
twpol pushed a commit that referenced this pull request Mar 15, 2025
@openrails-bot
Automatic merge of T1.5.1-1608-g273f2ef97 and 11 pull requests
581420e 
- Pull request #900 at b54024b: DMI in 3D cab + two more dials
- Pull request #1030 at d3ae4a2: Refactor settings, in prep for settings exporter
- Pull request #892 at 1f5ba4c: Signal Function OPP_SIG_ID_TRAINPATH
- Pull request #961 at ffccb2e: Improvements for Power Supplies
- Pull request #1015 at 1ade99e: Enhancements for EP brakes
- Pull request #1029 at 31fd7d2: Superelevation Follow Up Fixes
- Pull request #1031 at 34aa23a: Multiplayer Server, forked from Open Rails Ultimate; blueprint https://blueprints.launchpad.net/or/+spec/multiplayer-server
- Pull request #1047 at eb8027b: Docs: adds translation docs
- Pull request #1058 at 626ebed: Refactor notification parameters
- Pull request #1055 at d1a56b3: Route Based TTrack Sounds
- Pull request #896 at f1681df: First implementation of https://blueprints.launchpad.net/or/+spec/specific-sounds-for-ai-trains
twpol pushed a commit that referenced this pull request Mar 16, 2025
@openrails-bot
Automatic merge of T1.5.1-1608-g273f2ef97 and 11 pull requests
311a912 
- Pull request #900 at b54024b: DMI in 3D cab + two more dials
- Pull request #1030 at d3ae4a2: Refactor settings, in prep for settings exporter
- Pull request #892 at 1f5ba4c: Signal Function OPP_SIG_ID_TRAINPATH
- Pull request #961 at ffccb2e: Improvements for Power Supplies
- Pull request #1015 at 1ade99e: Enhancements for EP brakes
- Pull request #1029 at 31fd7d2: Superelevation Follow Up Fixes
- Pull request #1031 at 34aa23a: Multiplayer Server, forked from Open Rails Ultimate; blueprint https://blueprints.launchpad.net/or/+spec/multiplayer-server
- Pull request #1047 at eb8027b: Docs: adds translation docs
- Pull request #1058 at 626ebed: Refactor notification parameters
- Pull request #1055 at 1a01818: Route Based TTrack Sounds
- Pull request #896 at f1681df: First implementation of https://blueprints.launchpad.net/or/+spec/specific-sounds-for-ai-trains
twpol pushed a commit that referenced this pull request Mar 16, 2025
@openrails-bot
Automatic merge of T1.5.1-1608-g273f2ef97 and 11 pull requests
a3b27b2 
- Pull request #900 at b54024b: DMI in 3D cab + two more dials
- Pull request #1030 at d3ae4a2: Refactor settings, in prep for settings exporter
- Pull request #892 at 1f5ba4c: Signal Function OPP_SIG_ID_TRAINPATH
- Pull request #961 at ffccb2e: Improvements for Power Supplies
- Pull request #1015 at 1ade99e: Enhancements for EP brakes
- Pull request #1029 at 31fd7d2: Superelevation Follow Up Fixes
- Pull request #1031 at c097fd2: Multiplayer Server, forked from Open Rails Ultimate; blueprint https://blueprints.launchpad.net/or/+spec/multiplayer-server
- Pull request #1047 at eb8027b: Docs: adds translation docs
- Pull request #1058 at 626ebed: Refactor notification parameters
- Pull request #1055 at 1a01818: Route Based TTrack Sounds
- Pull request #896 at f1681df: First implementation of https://blueprints.launchpad.net/or/+spec/specific-sounds-for-ai-trains
twpol pushed a commit that referenced this pull request Mar 17, 2025
@openrails-bot
Automatic merge of T1.5.1-1608-g273f2ef97 and 12 pull requests
d2b598e 
- Pull request #900 at b54024b: DMI in 3D cab + two more dials
- Pull request #1030 at d3ae4a2: Refactor settings, in prep for settings exporter
- Pull request #892 at 1f5ba4c: Signal Function OPP_SIG_ID_TRAINPATH
- Pull request #961 at ffccb2e: Improvements for Power Supplies
- Pull request #1015 at 1ade99e: Enhancements for EP brakes
- Pull request #1029 at 31fd7d2: Superelevation Follow Up Fixes
- Pull request #1031 at c097fd2: Multiplayer Server, forked from Open Rails Ultimate; blueprint https://blueprints.launchpad.net/or/+spec/multiplayer-server
- Pull request #1047 at eb8027b: Docs: adds translation docs
- Pull request #1058 at 626ebed: Refactor notification parameters
- Pull request #1059 at 313f795: Fix F9 powersupply crashes
- Pull request #1055 at 1a01818: Route Based TTrack Sounds
- Pull request #896 at f1681df: First implementation of https://blueprints.launchpad.net/or/+spec/specific-sounds-for-ai-trains
twpol pushed a commit that referenced this pull request Mar 17, 2025
@openrails-bot
Automatic merge of T1.5.1-1613-g05d58921c and 12 pull requests
6115965 
- Pull request #900 at b54024b: DMI in 3D cab + two more dials
- Pull request #1030 at d3ae4a2: Refactor settings, in prep for settings exporter
- Pull request #892 at 1f5ba4c: Signal Function OPP_SIG_ID_TRAINPATH
- Pull request #961 at ffccb2e: Improvements for Power Supplies
- Pull request #1015 at 1ade99e: Enhancements for EP brakes
- Pull request #1029 at 31fd7d2: Superelevation Follow Up Fixes
- Pull request #1031 at c097fd2: Multiplayer Server, forked from Open Rails Ultimate; blueprint https://blueprints.launchpad.net/or/+spec/multiplayer-server
- Pull request #1047 at eb8027b: Docs: adds translation docs
- Pull request #1059 at 313f795: Fix F9 powersupply crashes
- Pull request #1061 at f75dc71: Fix F9 Web-page conflict.
- Pull request #1055 at 1a01818: Route Based TTrack Sounds
- Pull request #896 at f1681df: First implementation of https://blueprints.launchpad.net/or/+spec/specific-sounds-for-ai-trains
twpol pushed a commit that referenced this pull request Mar 17, 2025
@openrails-bot
Automatic merge of T1.5.1-1623-g53e9ed1ca and 11 pull requests
46b4f35 
- Pull request #900 at b54024b: DMI in 3D cab + two more dials
- Pull request #1030 at d3ae4a2: Refactor settings, in prep for settings exporter
- Pull request #892 at 1f5ba4c: Signal Function OPP_SIG_ID_TRAINPATH
- Pull request #961 at ffccb2e: Improvements for Power Supplies
- Pull request #1015 at 1ade99e: Enhancements for EP brakes
- Pull request #1029 at 31fd7d2: Superelevation Follow Up Fixes
- Pull request #1047 at eb8027b: Docs: adds translation docs
- Pull request #1059 at 313f795: Fix F9 powersupply crashes
- Pull request #1061 at f75dc71: Fix F9 Web-page conflict.
- Pull request #1055 at 1a01818: Route Based TTrack Sounds
- Pull request #896 at f1681df: First implementation of https://blueprints.launchpad.net/or/+spec/specific-sounds-for-ai-trains
twpol pushed a commit that referenced this pull request Mar 23, 2025
@openrails-bot
Automatic merge of T1.5.1-1630-gf3424409b and 9 pull requests
d516007 
- Pull request #900 at b54024b: DMI in 3D cab + two more dials
- Pull request #1030 at d3ae4a2: Refactor settings, in prep for settings exporter
- Pull request #892 at 1f5ba4c: Signal Function OPP_SIG_ID_TRAINPATH
- Pull request #961 at ffccb2e: Improvements for Power Supplies
- Pull request #1015 at 1ade99e: Enhancements for EP brakes
- Pull request #1029 at 31fd7d2: Superelevation Follow Up Fixes
- Pull request #1063 at 6c23191: Better Missing Track Section Error Message
- Pull request #1055 at 1a01818: Route Based TTrack Sounds
- Pull request #896 at f1681df: First implementation of https://blueprints.launchpad.net/or/+spec/specific-sounds-for-ai-trains
twpol pushed a commit that referenced this pull request Mar 24, 2025
@openrails-bot
Automatic merge of T1.5.1-1630-gf3424409b and 9 pull requests
dd7c6f0 
- Pull request #900 at b54024b: DMI in 3D cab + two more dials
- Pull request #1030 at d3ae4a2: Refactor settings, in prep for settings exporter
- Pull request #892 at 1f5ba4c: Signal Function OPP_SIG_ID_TRAINPATH
- Pull request #961 at ffccb2e: Improvements for Power Supplies
- Pull request #1015 at 1ade99e: Enhancements for EP brakes
- Pull request #1029 at 92c74ef: Superelevation Follow Up Fixes
- Pull request #1063 at 6c23191: Better Missing Track Section Error Message
- Pull request #1055 at 1a01818: Route Based TTrack Sounds
- Pull request #896 at f1681df: First implementation of https://blueprints.launchpad.net/or/+spec/specific-sounds-for-ai-trains
twpol pushed a commit that referenced this pull request Mar 24, 2025
@openrails-bot
Automatic merge of T1.5.1-1630-gf3424409b and 9 pull requests
70ddc14 
- Pull request #900 at b54024b: DMI in 3D cab + two more dials
- Pull request #1030 at d3ae4a2: Refactor settings, in prep for settings exporter
- Pull request #892 at 1f5ba4c: Signal Function OPP_SIG_ID_TRAINPATH
- Pull request #961 at ffccb2e: Improvements for Power Supplies
- Pull request #1015 at 1ade99e: Enhancements for EP brakes
- Pull request #1029 at 92c74ef: Superelevation Follow Up Fixes
- Pull request #1063 at 6c23191: Better Missing Track Section Error Message
- Pull request #1055 at 2b45594: Route Based TTrack Sounds
- Pull request #896 at f1681df: First implementation of https://blueprints.launchpad.net/or/+spec/specific-sounds-for-ai-trains
twpol pushed a commit that referenced this pull request Mar 24, 2025
@openrails-bot
Automatic merge of T1.5.1-1630-gf3424409b and 10 pull requests
0eae0cc 
- Pull request #900 at b54024b: DMI in 3D cab + two more dials
- Pull request #1030 at d3ae4a2: Refactor settings, in prep for settings exporter
- Pull request #1062 at 3b18c48: Train Forces popup Window.
- Pull request #892 at 1f5ba4c: Signal Function OPP_SIG_ID_TRAINPATH
- Pull request #961 at ffccb2e: Improvements for Power Supplies
- Pull request #1015 at 1ade99e: Enhancements for EP brakes
- Pull request #1029 at 92c74ef: Superelevation Follow Up Fixes
- Pull request #1063 at 6c23191: Better Missing Track Section Error Message
- Pull request #1055 at 2b45594: Route Based TTrack Sounds
- Pull request #896 at f1681df: First implementation of https://blueprints.launchpad.net/or/+spec/specific-sounds-for-ai-trains
twpol pushed a commit that referenced this pull request Mar 26, 2025
@openrails-bot
Automatic merge of T1.5.1-1630-gf3424409b and 10 pull requests
d84420d 
- Pull request #900 at b54024b: DMI in 3D cab + two more dials
- Pull request #1030 at d3ae4a2: Refactor settings, in prep for settings exporter
- Pull request #1062 at 3b18c48: Train Forces popup Window.
- Pull request #892 at 1f5ba4c: Signal Function OPP_SIG_ID_TRAINPATH
- Pull request #961 at ffccb2e: Improvements for Power Supplies
- Pull request #1015 at 1ade99e: Enhancements for EP brakes
- Pull request #1029 at 92c74ef: Superelevation Follow Up Fixes
- Pull request #1063 at 6c23191: Better Missing Track Section Error Message
- Pull request #1055 at 556ad1d: Route Based TTrack Sounds
- Pull request #896 at f1681df: First implementation of https://blueprints.launchpad.net/or/+spec/specific-sounds-for-ai-trains
twpol pushed a commit that referenced this pull request Mar 26, 2025
@openrails-bot
Automatic merge of T1.5.1-1630-gf3424409b and 10 pull requests
12f283f 
- Pull request #900 at b54024b: DMI in 3D cab + two more dials
- Pull request #1030 at d3ae4a2: Refactor settings, in prep for settings exporter
- Pull request #1062 at 3b18c48: Train Forces popup Window.
- Pull request #892 at 1f5ba4c: Signal Function OPP_SIG_ID_TRAINPATH
- Pull request #961 at ffccb2e: Improvements for Power Supplies
- Pull request #1015 at 1ade99e: Enhancements for EP brakes
- Pull request #1029 at 92c74ef: Superelevation Follow Up Fixes
- Pull request #1063 at 6c23191: Better Missing Track Section Error Message
- Pull request #1055 at d133921: Route Based TTrack Sounds
- Pull request #896 at f1681df: First implementation of https://blueprints.launchpad.net/or/+spec/specific-sounds-for-ai-trains
@cesarBLG
Copy link
Contributor Author

cesarBLG commented Mar 28, 2025

Hi @pzgulyas the blueprint is now approved. I solved the merge conflicts (which cancelled your review). Could you re-approve it? Thanks

twpol pushed a commit that referenced this pull request Mar 28, 2025
@openrails-bot
Automatic merge of T1.5.1-1630-gf3424409b and 11 pull requests
f7ad19a 
- Pull request #900 at b54024b: DMI in 3D cab + two more dials
- Pull request #1030 at d3ae4a2: Refactor settings, in prep for settings exporter
- Pull request #1062 at 3b18c48: Train Forces popup Window.
- Pull request #892 at 1f5ba4c: Signal Function OPP_SIG_ID_TRAINPATH
- Pull request #961 at ffccb2e: Improvements for Power Supplies
- Pull request #1015 at 1ade99e: Enhancements for EP brakes
- Pull request #1029 at 92c74ef: Superelevation Follow Up Fixes
- Pull request #1063 at 6c23191: Better Missing Track Section Error Message
- Pull request #1065 at eb49b25: Fix for PantographToggle sound event
- Pull request #1055 at d133921: Route Based TTrack Sounds
- Pull request #896 at f1681df: First implementation of https://blueprints.launchpad.net/or/+spec/specific-sounds-for-ai-trains
twpol pushed a commit that referenced this pull request Mar 28, 2025
@openrails-bot
Automatic merge of T1.5.1-1630-gf3424409b and 11 pull requests
ada1bb5 
- Pull request #900 at b54024b: DMI in 3D cab + two more dials
- Pull request #1030 at d3ae4a2: Refactor settings, in prep for settings exporter
- Pull request #1062 at 3b18c48: Train Forces popup Window.
- Pull request #892 at 1f5ba4c: Signal Function OPP_SIG_ID_TRAINPATH
- Pull request #961 at ffccb2e: Improvements for Power Supplies
- Pull request #1015 at 1ade99e: Enhancements for EP brakes
- Pull request #1029 at 92c74ef: Superelevation Follow Up Fixes
- Pull request #1063 at 6c23191: Better Missing Track Section Error Message
- Pull request #1065 at 409064d: Fix for PantographToggle sound event
- Pull request #1055 at d133921: Route Based TTrack Sounds
- Pull request #896 at f1681df: First implementation of https://blueprints.launchpad.net/or/+spec/specific-sounds-for-ai-trains
pzgulyas
pzgulyas approved these changes Mar 29, 2025
View reviewed changes
Copy link
Contributor

@pzgulyas pzgulyas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I cannot spot any problems with these changes.

@cesarBLG
Copy link
Contributor Author

cesarBLG commented Mar 29, 2025

Thanks!

@cesarBLG cesarBLG merged commit f88b8b9 into openrails:master Mar 29, 2025
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@pzgulyas pzgulyas pzgulyas approved these changes

Assignees

No one assigned

Labels

enhancement New feature or request

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@cesarBLG @peternewell @cjakeman @SteelFill @Sharpe49 @pzgulyas