Warnings Property #172
Merged
Warnings Property #172
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## dev #172 +/- ##
==========================================
+ Coverage 98.59% 98.60% +0.01%
==========================================
Files 11 11
Lines 1699 1707 +8
Branches 162 162
==========================================
+ Hits 1675 1683 +8
Misses 5 5
Partials 19 19 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
sadrasabouri
requested changes
Oct 18, 2025
memor/message.py
Outdated
| return self.get_size() | ||
|
|
||
| @property | ||
| def warnings(self) -> Dict[str, Union[float, bool]]: |
There was a problem hiding this comment.
I guess it should be Dict[str, Dict[str, Union[float, bool]]]:
memor/session.py
Outdated
| return self.get_size() | ||
|
|
||
| @property | ||
| def warnings(self) -> Dict[str, Union[float, bool]]: |
sadrasabouri
approved these changes
Oct 18, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reference Issues/PRs
#98
What does this implement/fix? Explain your changes.
Responseclasswarningsproperty addedPromptclasswarningsproperty addedSessionclasswarningsproperty addedAny other comments?