-
Notifications
You must be signed in to change notification settings - Fork 462
OCPNODE-2482: Enable CRI-O internal repair feature as the default #4519
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
OCPNODE-2482: Enable CRI-O internal repair feature as the default #4519
Conversation
|
@kwilczynski: This pull request references OCPNODE-1784 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the epic to target the "4.18.0" version, but no target version was set. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
/assign kwilczynski |
|
/cherry-pick release-4.17 |
|
@kwilczynski: once the present PR merges, I will cherry-pick it on top of release-4.17 in a new PR and assign it to you. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
/approve |
|
/lgtm |
|
/retest |
|
@kwilczynski: This pull request references OCPNODE-1784 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the epic to target the "4.18.0" version, but no target version was set. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
@kwilczynski: This pull request references OCPNODE-2482 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.18.0" version, but no target version was set. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
/retest |
|
/skip |
|
/skip |
1 similar comment
|
/skip |
|
/retest |
|
/test e2e-aws-ovn-upgrade |
|
/skip |
|
/retest |
|
@cri-o/cri-o-maintainers, please have a look. Thank you! |
|
/retest |
|
/hold Revision 1ba88c3 was retested 3 times: holding |
Signed-off-by: Krzysztof Wilczyński <[email protected]>
1ba88c3 to
f8db91e
Compare
|
/unhold |
|
/skip |
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: haircommander, kwilczynski The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
@kwilczynski: all tests passed! Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
|
@kwilczynski: new pull request created: #4535 DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
[ART PR BUILD NOTIFIER] Distgit: ose-machine-config-operator |
- What I did
For a while now, CRI-O can attempt to repair the storage directory on start-up following an unclean shutdown, such as a node crash or unexpected restart. This allows CRI-O to recover from a storage directory corruption, alleviating potential crashes or termination with a fatal error once it's started back up.
However, this internal repair feature has to be enabled to take effect, so it's currently an opt-in solution. This feature has matured and can be turned on as the new default when deploying OpenShift clusters. As a result, our customers will benefit from improved cluster resilience.
Thus, turn the internal feature on as the new default.
Related:
- How to verify it
Deploy updated configuration manually or using either the Machine Config Operator.
Then, to verify the internal repair feature working, proceed using the following steps:
(assuming that the test will be performed using an OpenShift cluster with privileged access available)
/var/lib/containersdirectory/var/lib/crio/clean.shutdownfile to simulate CRI-O unclean shutdown- Description for the changelog