-
Notifications
You must be signed in to change notification settings - Fork 858
unbound: merge extended blocklists into core (https://github.com/opnsense/core/issues/9136) #9301
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
src/opnsense/mvc/app/controllers/OPNsense/Unbound/forms/dnsbl.xml
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks good on the surface
One thing to note here is that with many blocklists, the matching algorithm has quite a performance penalty due to the subnet coverage calculation. This doesn't necessarily have to be a problem, as it's properly locked and is only for pre-processing, but it's slower than before. |
0e8b7b5
to
db13acb
Compare
…bnet coverage calculation
…ks in dynamic tooltips
Just to ease review a bit, the data path is as follows:
|
TODO:
post()
usage to clean up config.