Fix #5818: Add comprehensive tests for EditTextInputAction append/rep… #5944

shrimpnaur · 2025-08-29T15:11:38Z

This PR addresses part of #5818 by adding comprehensive tests for EditTextInputAction to verify correct append and replace text behavior in Robolectric environments.

What This PR Does

Adds EditTextInputActionTest.kt with comprehensive test coverage for EditTextInputAction
Tests appendText() correctly appends to existing text (e.g., "123" + "45" = "12345")
Tests replaceText() correctly replaces existing text (e.g., "123" → "45")
Covers edge cases like empty text, special characters, and mixed operations
Ensures the fix from PR Fixes a part of #2133: Prevent vanishing of input on configuration change. #5617 works correctly and prevents future regressions

Testing

All tests verify the behavior works correctly in Robolectric environments where the original bug occurred
Tests cover both isAppend=true and isAppend=false code paths in the updateText() method
Includes tests for sequential operations and edge cases

The core bug fix was already implemented in PR #5617. This PR adds the missing test coverage as specified in issue #5818.

Fixes part of #5818

Essential Checklist

The PR title and explanation each start with "Fix #bugnum: " (If this PR fixes part of an issue, prefix the title with "Fix part of #bugnum: ...".)
Any changes to scripts/assets files have their rationale included in the PR explanation.
The PR follows the style guide.
The PR does not contain any unnecessary code changes from Android Studio (reference).
The PR is made from a branch that's not called "develop" and is up-to-date with "develop".
The PR is assigned to the appropriate reviewers (reference).

…d/replace functionality

shrimpnaur · 2025-08-29T15:19:30Z

PTAL @theayushyadav11

theayushyadav11

Thanks @shrimpnaur, this is nicely done. Just a few nits regarding test namings (guide) and arrangement.

testing/src/test/java/org/oppia/android/testing/espresso/EditTextInputActionTest.kt

theayushyadav11 · 2025-08-30T23:05:06Z

Hi @shrimpnaur, just a small request, please avoid resolving comments that were not opened by you. Instead, you can respond with "Done," "Updated," or share any thoughts you have. The reviewer will take care of resolving the comments.
Thanks

shrimpnaur · 2025-09-02T08:24:34Z

Understood and resolved the comments. PTAL @theayushyadav11

oppiabot · 2025-09-02T08:27:38Z

Unassigning @shrimpnaur since a re-review was requested. @shrimpnaur, please make sure you have addressed all review comments. Thanks!

shrimpnaur · 2025-09-06T15:03:55Z

@theayushyadav11 Hey there, just wanted to check up on this. Does everything work as intended?

adhiamboperes · 2025-09-06T19:40:23Z

Hi @shrimpnaur, apologies for the delay. We will give you a full review tomorrow.

theayushyadav11 · 2025-09-06T19:47:29Z

Thanks @shrimpnaur for addressing the comments. This LGTM.
I have updated the branch to adhere to latest develop branch.
@adhiamboperes PTAL for the final pass.

oppiabot · 2025-09-06T19:51:15Z

Unassigning @theayushyadav11 since they have already approved the PR.

oppiabot · 2025-09-06T19:51:18Z

Assigning @BenHenning for code owner reviews. Thanks!

github-actions · 2025-09-06T20:32:18Z

Coverage Report

Results

Number of files assessed: 1
Overall Coverage: 0.00%
Coverage Analysis: PASS ✅

Exempted coverage

Files exempted from coverage

File	Exemption Reason
EditTextInputAction.kt testing/src/main/java/org/oppia/android/testing/espresso/EditTextInputAction.kt	This file is exempted from having a test file; skipping coverage check.

Refer test_file_exemptions.textproto for the comprehensive list of file exemptions and their required coverage percentages.

To learn more, visit the Oppia Android Code Coverage wiki page

adhiamboperes

Thanks @shrimpnaur for this PR. I am handing this over to @BenHenning to help with the technical decisions.

testing/src/test/java/org/oppia/android/testing/espresso/BUILD.bazel

adhiamboperes · 2025-09-11T14:02:35Z

testing/src/test/java/org/oppia/android/testing/espresso/EditTextInputActionTest.kt

+ * in Robolectric environments.
+ */
+@RunWith(AndroidJUnit4::class)
+@Config(application = EditTextInputActionTest.TestApplication::class)


These tests are good if the goal is lightweight unit tests, but the common pattern in the repo is to use instrumented unit tests/ semi integration tests like in TextInputActionTest.kt.

I would like @BenHenning to weigh in here, whether we should go with this approach.

I agree. The variety of tests is really good, but we ought to ensure that the action actually integrates with Espresso correctly (which means using it as an Espresso action rather than directly calling it). TextInputActionTest is a really good basis for reference on how to do that since it's also validating a custom Espresso action.

shrimpnaur · 2025-09-15T11:05:09Z

@BenHenning @adhiamboperes

Thank you for the feedback. I understand that these are architectural decisions that need your input.

Could you please let me know if I should wait for the technical decisions before making any changes?
and also if there is there anything I can help clarify about my current implementation while you're reviewing the approach?

I'm happy to adjust the implementation once the preferred approach is determined.

adhiamboperes · 2025-09-15T11:14:38Z

Hi @shrimpnaur, I understand that you are blocked on this PR. It would be great to work on a new issue in the meantime, to parallelize your efforts. We have updated our list of starter issues, so I hope you find some interesting stuff to work on!

shrimpnaur · 2025-09-15T11:53:56Z

@adhiamboperes Yeah sure. 👍

oppiabot · 2025-09-22T12:12:48Z

Hi @shrimpnaur, I'm going to mark this PR as stale because it hasn't had any updates for 7 days. If no further activity occurs within 7 days, it will be automatically closed so that others can take up the issue.
If you are still working on this PR, please make a follow-up commit within 3 days (and submit it for review, if applicable). Please also let us know if you are stuck so we can help you!

BenHenning

Thanks @shrimpnaur! Apologies for the delay--I was sick and it took a number of days to catch up on things. I've followed up to @adhiamboperes's comments--PTAL.

testing/src/test/java/org/oppia/android/testing/espresso/BUILD.bazel

BenHenning · 2025-09-24T01:02:58Z

testing/src/test/java/org/oppia/android/testing/espresso/EditTextInputActionTest.kt

+ * in Robolectric environments.
+ */
+@RunWith(AndroidJUnit4::class)
+@Config(application = EditTextInputActionTest.TestApplication::class)


I agree. The variety of tests is really good, but we ought to ensure that the action actually integrates with Espresso correctly (which means using it as an Espresso action rather than directly calling it). TextInputActionTest is a really good basis for reference on how to do that since it's also validating a custom Espresso action.

shrimpnaur · 2025-09-28T16:10:57Z

Hi @BenHenning ,
Thanks for the clarification! I’ll leave the BUILD.bazel file as is and update the my test by following the pattern in TextInputActionTest.kt so that there is proper integration with Espresso.

I'll make these changes and update the PR shortly.
Thanks for the guidance!

oppiabot · 2025-10-05T16:14:20Z

Hi @shrimpnaur, I'm going to mark this PR as stale because it hasn't had any updates for 7 days. If no further activity occurs within 7 days, it will be automatically closed so that others can take up the issue.
If you are still working on this PR, please make a follow-up commit within 3 days (and submit it for review, if applicable). Please also let us know if you are stuck so we can help you!

adhiamboperes · 2025-10-08T12:52:54Z

Hi @shrimpnaur, do you need support on this PR?

shrimpnaur · 2025-10-09T13:22:30Z

Hey @adhiamboperes
I'm working on updating the tests, but I need guidance on which test activity to use. Should I:

Use an existing test activity like InputInteractionViewTestActivity?
Create a new dedicated test activity for EditTextInputAction?

Could you point me to the best approach for this?

Thanks!

adhiamboperes · 2025-10-10T12:48:46Z

Hi @shrimpnaur, please create a new test activity as it is fairly simple. Also make sure you add the activity to the test_file_exemptions file, as well as to the testing module's AndroidManifest and the CODEOWNERS file, following the example of TextInputActionTestActivity.

oppiabot · 2025-10-17T13:16:07Z

Hi @shrimpnaur, I'm going to mark this PR as stale because it hasn't had any updates for 7 days. If no further activity occurs within 7 days, it will be automatically closed so that others can take up the issue.
If you are still working on this PR, please make a follow-up commit within 3 days (and submit it for review, if applicable). Please also let us know if you are stuck so we can help you!

Fix oppia#5818: Add comprehensive tests for EditTextInputAction appen…

f300c3b

…d/replace functionality

shrimpnaur requested review from a team as code owners August 29, 2025 15:11

shrimpnaur requested a review from BenHenning August 29, 2025 15:11

oppiabot bot assigned theayushyadav11 Aug 29, 2025

theayushyadav11 requested changes Aug 29, 2025

View reviewed changes

theayushyadav11 assigned shrimpnaur and unassigned theayushyadav11 Aug 29, 2025

Address review feedback: Update test naming and organization

03b8224

Address review feedback: Update test naming and organization

d37a9ab

oppiabot bot assigned theayushyadav11 Sep 2, 2025

oppiabot bot unassigned shrimpnaur Sep 2, 2025

Merge branch 'develop' into edittextinput-tests-v2

b11e472

theayushyadav11 approved these changes Sep 6, 2025

View reviewed changes

oppiabot bot unassigned theayushyadav11 Sep 6, 2025

oppiabot bot assigned BenHenning Sep 6, 2025

adhiamboperes requested changes Sep 11, 2025

View reviewed changes

adhiamboperes assigned shrimpnaur Sep 11, 2025

adhiamboperes unassigned shrimpnaur Sep 15, 2025

oppiabot bot added the stale Corresponds to items that haven't seen a recent update and may be automatically closed. label Sep 22, 2025

BenHenning reviewed Sep 24, 2025

View reviewed changes

oppiabot bot removed the stale Corresponds to items that haven't seen a recent update and may be automatically closed. label Sep 24, 2025

BenHenning assigned shrimpnaur and unassigned BenHenning Sep 24, 2025

oppiabot bot added the stale Corresponds to items that haven't seen a recent update and may be automatically closed. label Oct 5, 2025

oppiabot bot removed the stale Corresponds to items that haven't seen a recent update and may be automatically closed. label Oct 8, 2025

oppiabot bot added the stale Corresponds to items that haven't seen a recent update and may be automatically closed. label Oct 17, 2025

oppiabot bot closed this Oct 24, 2025

Fix #5818: Add comprehensive tests for EditTextInputAction append/rep… #5944

Fix #5818: Add comprehensive tests for EditTextInputAction append/rep… #5944

Uh oh!

Conversation

shrimpnaur commented Aug 29, 2025 • edited by BenHenning Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

What This PR Does

Testing

Essential Checklist

Uh oh!

shrimpnaur commented Aug 29, 2025

Uh oh!

theayushyadav11 left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

theayushyadav11 commented Aug 30, 2025

Uh oh!

shrimpnaur commented Sep 2, 2025

Uh oh!

oppiabot bot commented Sep 2, 2025

Uh oh!

shrimpnaur commented Sep 6, 2025

Uh oh!

adhiamboperes commented Sep 6, 2025

Uh oh!

theayushyadav11 commented Sep 6, 2025

Uh oh!

oppiabot bot commented Sep 6, 2025

Uh oh!

oppiabot bot commented Sep 6, 2025

Uh oh!

github-actions bot commented Sep 6, 2025

Coverage Report

Results

Exempted coverage

Uh oh!

adhiamboperes left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

adhiamboperes Sep 11, 2025

Choose a reason for hiding this comment

Uh oh!

BenHenning Sep 24, 2025

Choose a reason for hiding this comment

Uh oh!

shrimpnaur commented Sep 15, 2025

Uh oh!

adhiamboperes commented Sep 15, 2025

Uh oh!

shrimpnaur commented Sep 15, 2025

Uh oh!

oppiabot bot commented Sep 22, 2025

Uh oh!

BenHenning left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

BenHenning Sep 24, 2025

Choose a reason for hiding this comment

Uh oh!

shrimpnaur commented Sep 28, 2025

Uh oh!

oppiabot bot commented Oct 5, 2025

Uh oh!

adhiamboperes commented Oct 8, 2025

Uh oh!

shrimpnaur commented Oct 9, 2025

Uh oh!

adhiamboperes commented Oct 10, 2025

shrimpnaur commented Aug 29, 2025 •

edited by BenHenning

Loading