Normalizes the URL created from paths in LibSVMDataSource#181
Merged
Conversation
…th relative path issues in round-tripping the provenance.
Craigacp
added a commit
that referenced
this pull request
Dec 9, 2021
* Normalizing the URL created from paths in LibSVMDataSource to deal with relative path issues in round-tripping the provenance. * More normalization for LibSVMDataSource's paths.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This change normalizes the path before it is converted into a URL in LibSVMDataSource. Adds a test for the fixed behaviour.
Motivation
LibSVMDataSource.postConfigchecks to see if the URL and path are the same before throwing an exception if both are set. TheFileProvenanceconstructor normalizes and absolutes the path before it is created, however the original codepath inLibSVMDataSourcedid not do this to the URL which is created. This means if the path has a relative element in it like.or..then the URL created retains the relative element and the path has it normalized out, meaning the two values are not equal and an exception is thrown when the configuration is instantiated from the provenance of aLibSVMDataSource.