refactor: Move verbose into printer object #1406
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2fdb89c to
40d5625
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1406 +/- ##
=======================================
Coverage 85.01% 85.01%
=======================================
Files 107 107
Lines 3790 3790
=======================================
Hits 3222 3222
Misses 339 339
Partials 229 229 ☔ View full report in Codecov by Sentry. |
qweeah
reviewed
Jun 17, 2024
qweeah
reviewed
Jun 17, 2024
qweeah
reviewed
Jun 17, 2024
qweeah
approved these changes
Jun 17, 2024
Contributor
qweeah
left a comment
There was a problem hiding this comment.
LGTM with minor suggestions.
Signed-off-by: Terry Howe <[email protected]>
40d5625 to
76d3cfc
Compare
6 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
The verbose option should be owned by the printer.