Allow PR reviewers to comment on *unchanged* files #9099
Replies: 132 comments 34 replies
-
|
I have another use case for this. A PR contained changes that caused stale code in another file. I couldn't add a comment on the stale code in my PR review. |
Beta Was this translation helpful? Give feedback.
-
|
@Twizzle1 that's a perfectly valid use case |
Beta Was this translation helpful? Give feedback.
-
|
I have a use case in hand that could be solved by this proposed change. I have a PR that makes some small changes in a specific area of the codebase. This whole area was added recently, but for unrelated reasons, I've not had an opportunity to review this whole area at all when it was added. And since the current PR has drawn my attention to this - I want to use this opportunity, expand the scope of PR and review the whole newly added area altogether, including files that haven't been changed by this specific PR in hand. This is similar to a code audit, i.e. situation where a review is needed on a codebase in it's present state, without any changes whatsoever, but I guess it would be much easier to allow commenting on any files within a context of PR than to invent a whole new concept of a code audit outside of PR context. |
Beta Was this translation helpful? Give feedback.
-
|
Yea this is a much needed feature. Some codebases can be complex and good reviews might quickly grow in scope from just the changes of the dev to a much larger set if the PR being reviewed touches/interacts with many systems indirectly |
Beta Was this translation helpful? Give feedback.
-
|
Speaking for everyone who's subscribed to this discussion: Everyone please STOP just commenting If you just want to show your support for this feature request: Please use the If you have a new argument or usecase where this would be relevant: Please double check that it isn't already in a comment. If it is, please just use the Thank you in advance. Footnotes
|
Beta Was this translation helpful? Give feedback.
-
|
If you are the OP, it's easy to find the issue/discussion (just search under Meanwhile, as neither the OP nor a maintainer, I've gotten pinged on the "Organization gists" discussion roughly once every day or two for the last x months, and all I ever find is |
Beta Was this translation helpful? Give feedback.
-
|
How about directing comments about this notification issue to #53075 now that it's got a home? |
Beta Was this translation helpful? Give feedback.
-
|
|
Beta Was this translation helpful? Give feedback.
-
|
@luke-pk In defense of those complaining, I imagine they are subscribed so that they can be alerted to any progress, discussion, or official acknowledgement of the issue. The core complaint, then, is that they are forced to choose between having an uncluttered inbox and actually staying informed. Unsubscribing doesn't really address that, it's just one of the two evils they aren't satisfied with picking the lesser of. Personally I find all the +1 emails kind of amusing 😛 |
Beta Was this translation helpful? Give feedback.
-
|
Perhaps GitHub needs to provide us a way to contribute this feature back into the mainline. We have enough people on this thread for a full development and QA headcount. |
Beta Was this translation helpful? Give feedback.
-
|
Really surprised this doesn't exist tbh - I thought I simply didn't know how to find it. But yes, it's extremely common during a PR review to find that a dev missed some related changes elsewhere in the codebase, & it seems currently there's no way to flag those. i.e. maybe they're refactoring references to a particular entity, but missed one of those references. As far as I can tell, there's no way to propose that as a change, in the spot where it actually needs to happen. |
Beta Was this translation helpful? Give feedback.
-
|
I think it's safe to say that most of the people find it weird that they can't go say on line 62 something simple as "please also update this". |
Beta Was this translation helpful? Give feedback.
-
|
This tends to be the scenario I am hitting most of the time. Something was missed in other parts of the file I am reviewing and I cannot comment on it other that copy / pasting the code in the comment. |
Beta Was this translation helpful? Give feedback.
-
|
Extremely necessary for translators – when you need to correct mistakes in an already existing translation file, but missed by the author of an already opened PR. |
Beta Was this translation helpful? Give feedback.
This comment was marked as off-topic.
This comment was marked as off-topic.
This comment was marked as off-topic.
This comment was marked as off-topic.
-
|
my use case would be an automated "hey you need to bump the version in this config file, here's a suggestion you can commit" what's the latest status here? what's blocking the implementation? |
Beta Was this translation helpful? Give feedback.
-
|
+1 |
Beta Was this translation helpful? Give feedback.
-
|
+1 |
Beta Was this translation helpful? Give feedback.
-
|
This would be very useful for large codebases in which old code needed to be removed/changed but was not... having to reference a line # and/or link to the code in a comment is very inconvenient. |
Beta Was this translation helpful? Give feedback.
-
|
Can we please make this happen? It's been two whole years already 🙄 |
Beta Was this translation helpful? Give feedback.
-
|
It is incredibly disappointing that this still isn't implemented. |
Beta Was this translation helpful? Give feedback.
-
|
I still want this :) |
Beta Was this translation helpful? Give feedback.
-
|
I gree this would be very useful as well, has there been any update on this proposed feature? |
Beta Was this translation helpful? Give feedback.
This comment was marked as off-topic.
This comment was marked as off-topic.
-
|
I would also like to have this feature. I frequently find myself needing to do this. |
Beta Was this translation helpful? Give feedback.
-
|
The ability to comment not only on unchanged files, but also on unchanged lines of changed files for the very same reason that original poster mentioned. |
Beta Was this translation helpful? Give feedback.
-
|
Another very simple example, in a svelte file (also applies to vue/vanilla/whatever), within the same file, the commit removed an html element without deleting the corresponding style. |
Beta Was this translation helpful? Give feedback.
-
|
I was just looking for a way to do this. The PR flow is excellent, from the notifications to the UI and interactions in comments. My main use cases are
Other solutions that are talked about is to manipulate the timestamp from Terminal/Command-line don't work and are shady. This would be a great addition and seems a few others agree. 🤞 |
Beta Was this translation helpful? Give feedback.
-
|
+1 here. Thank you! |
Beta Was this translation helpful? Give feedback.
-
|
I posted a potential (but far away from being ideal) solution for everyone who just wants to automate things using the API in another thread here. |
Beta Was this translation helpful? Give feedback.
-
|
I can also really use this feature right now! |
Beta Was this translation helpful? Give feedback.
-
|
I would love this feature as well. |
Beta Was this translation helpful? Give feedback.
-
|
This would be really useful, to point out directly where extra changes would be needed to address a PR's intended changes |
Beta Was this translation helpful? Give feedback.
-
|
+1 |
Beta Was this translation helpful? Give feedback.
-
|
I have a use-case for this feature as well. Before this is implemented I'll probably have to rely on some workaround like this "Hey, author, run the following on your working tree: some_command_that_applies_relevant_changes_to_files" |
Beta Was this translation helpful? Give feedback.
-
|
I completely agree with your suggestion allowing PR review comments on unmodified files, in addition to unmodified lines in modified files, would indeed be very useful. It would allow reviewers to provide feedback on related files that may have been overlooked and ensure consistency across the codebase. This feature would enhance the review process and help address changes that need to be applied across multiple files. This is all from my side. Thanks |
Beta Was this translation helpful? Give feedback.
-
|
I had no idea it was not a feature haha I think it would be useful. |
Beta Was this translation helpful? Give feedback.
-
|
+1 |
Beta Was this translation helpful? Give feedback.
-
|
This will be a very useful feat. Please consider to add it. |
Beta Was this translation helpful? Give feedback.
-
|
We need this feat, pls consider to add them |
Beta Was this translation helpful? Give feedback.
-
|
Did you guys just forget about this, or...? |
Beta Was this translation helpful? Give feedback.
Uh oh!
There was an error while loading. Please reload this page.
-
Allow PR review comments on files not included (unchanged) in a pull request. This is useful when a PR reviewer needs to tell the PR author about a change they may have missed in a file that was not changed in that pull request.
From @mabwah-arista
This discussion was split out from an existing, related discussion 4452 that focused on commenting on any line of a changed file.
Beta Was this translation helpful? Give feedback.
All reactions