Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Conversation

@dmitrym0
Copy link
Member

@dmitrym0 dmitrym0 commented Mar 6, 2025

Problem

Unit tests started failing: https://github.com/org-noter/org-noter/actions/runs/13670129486

Solution

A moderately sized can of worms:

  1. Org version has been updated and is slightly incompatible. Updated unit tests to work with the latest org, and hardcoded the expected version of org so that we'll get notified when it changes by unit tests breaking.
  2. EmacSQL which is used by org-roam doesn't work with Emacs 28. Bumped version of emacs to 30.1.

The downside is, we're leaving Emacs 28/29 behind but this is the expedient fix.

Note that unit tests are also not required. If they fail, you can still merge the PR.

Checklist

  • I checked the code to make sure that it works on my machine.
  • I checked that the code works without my custom emacs config.
  • I added unit tests.

Steps to Test

  1. Install cask.
  2. Run cask install to install dependencies.
  3. Run make test.

@dmitrym0 dmitrym0 marked this pull request as ready for review March 6, 2025 19:55
@dmitrym0
Copy link
Member Author

dmitrym0 commented Mar 6, 2025

@petermao

@petermao
Copy link
Member

thanks Dmitry! So it wasn't my commit that broke things?

@dmitrym0 dmitrym0 merged commit a28f612 into master Mar 10, 2025
3 checks passed
@dmitrym0 dmitrym0 deleted the fix-unit-tests branch March 10, 2025 17:04
@dmitrym0
Copy link
Member Author

@petermao nope, not at all! Changes to org, Emacs itself and EmacSQL.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants