Thanks to visit codestin.com
Credit goes to github.com

Skip to content

feature: search on groups in legend search #2217

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

feature: search on groups in legend search #2217

wants to merge 2 commits into from

Conversation

@johnnyblasta
Copy link
Collaborator

@johnnyblasta johnnyblasta commented Aug 20, 2025

Closes #2216

@Grammostola
Copy link
Contributor

Grammostola commented Aug 26, 2025

Nice. It seems to work well, which includes turning on all layers in the selected search hit (group) and not including the layers of any subgroup. And it finds subgroups too.

  • For exclusive the last (bottom) layer of the group is activated (maybe the top layer would be more intuitive but I don't have a real opinion here).
  • For toggleAll: false subgroups, it activates all their layers. Have no opinion here either since the toggleAll button is gone and maybe that is the specific point of toggleAll: false

@johnnyblasta
Copy link
Collaborator Author

johnnyblasta commented Sep 22, 2025

Noticed that a layer which the user hasn't access to, keypad icon, is tried to be set to visible and therefore the icon is changed to selected icon. Which makes it visual confussing since it looks like the layer is visible, which it isn't since the backend hinders it.

@steff-o steff-o mentioned this pull request Nov 3, 2025
Open
steff-o
steff-o approved these changes Nov 5, 2025
View reviewed changes
Copy link
Contributor

@steff-o steff-o left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

One could argue that if the first layer in an exclusive group is secure, no layer in the group will be selected, but it seems strange to have an exclusive group where you have access to some layers but not all . But the expected behavior in such case is not obvious anyway and could very well be that no layer should be visible.

@steff-o steff-o added the PR approved To highlight approved PR:s as it is not shown in list which are approved. label Nov 5, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@steff-o steff-o steff-o approved these changes

Assignees

No one assigned

Labels

PR approved To highlight approved PR:s as it is not shown in list which are approved.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Legend search should include groups

4 participants

@johnnyblasta @Grammostola @steff-o