Thanks to visit codestin.com
Credit goes to github.com

Skip to content

fix: restore ability to override auth and token urls for exemplary app #3590

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Aug 3, 2023
Merged

fix: restore ability to override auth and token urls for exemplary app #3590

merged 1 commit into from
Aug 3, 2023

Conversation

@dpeckett
Copy link
Contributor

@dpeckett dpeckett commented Aug 2, 2023

Restore ability to override auth and token urls for exemplary app, looks like this was accidentally broken in the past.

Checklist

  • I have read the contributing guidelines.
  • I have referenced an issue containing the design document if my change
    introduces a new feature.
  • I am following the
    contributing code guidelines.
  • I have read the security policy.
  • I confirm that this pull request does not address a security
    vulnerability. If this pull request addresses a security vulnerability, I
    confirm that I got the approval (please contact
    [email protected]) from the maintainers to push
    the changes.
  • I have added tests that prove my fix is effective or that my feature
    works.
  • I have added or changed the documentation.

@dpeckett dpeckett requested a review from aeneasr as a code owner August 2, 2023 10:40
@dpeckett dpeckett changed the title fix: Restore ability to override auth and token urls for exemplary app fix: restore ability to override auth and token urls for exemplary app Aug 2, 2023
@codecov
Copy link

codecov bot commented Aug 2, 2023

Codecov Report

Merging #3590 (a8f0220) into master (749eb8d) will decrease coverage by 0.04%.
Report is 1 commits behind head on master.
The diff coverage is 0.00%.

❗ Current head a8f0220 differs from pull request most recent head 18eb2bc. Consider uploading reports for the commit 18eb2bc to get more accurate results

@@            Coverage Diff             @@
##           master    #3590      +/-   ##
==========================================
- Coverage   76.41%   76.38%   -0.04%     
==========================================
  Files         130      130              
  Lines        9714     9739      +25     
==========================================
+ Hits         7423     7439      +16     
- Misses       1792     1797       +5     
- Partials      499      503       +4
Files Changed Coverage Δ
cmd/cmd_perform_authorization_code.go 13.25% <0.00%> (-0.30%) ⬇️

... and 2 files with indirect coverage changes

aeneasr
aeneasr approved these changes Aug 3, 2023
View reviewed changes
Copy link
Member

@aeneasr aeneasr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome, thank you! 🎉 Your contribution makes Ory better :)

@aeneasr aeneasr merged commit dfb129a into ory:master Aug 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@aeneasr aeneasr aeneasr approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@dpeckett @aeneasr