Thanks to visit codestin.com
Credit goes to github.com

Skip to content

fix(sdk): rust compile issue with required enum #2619

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Jul 26, 2022
Merged

fix(sdk): rust compile issue with required enum #2619

merged 3 commits into from
Jul 26, 2022

Conversation

@aeneasr
Copy link
Member

@aeneasr aeneasr commented Jul 26, 2022

Related issue(s)

Checklist

  • I have read the contributing guidelines.
  • I have referenced an issue containing the design document if my change introduces a new feature.
  • I am following the contributing code guidelines.
  • I have read the security policy.
  • I confirm that this pull request does not address a security vulnerability.
    If this pull request addresses a security. vulnerability,
    I confirm that I got green light (please contact [email protected]) from the maintainers to push the changes.
  • I have added tests that prove my fix is effective or that my feature works.
  • I have added or changed the documentation.

Further Comments

@aeneasr aeneasr requested a review from zepatrik as a code owner July 26, 2022 09:41
@codecov
Copy link

codecov bot commented Jul 26, 2022

Codecov Report

Merging #2619 (d0a240c) into master (aaabe75) will decrease coverage by 0.01%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master    #2619      +/-   ##
==========================================
- Coverage   75.29%   75.28%   -0.02%     
==========================================
  Files         295      295              
  Lines       16627    16627              
==========================================
- Hits        12519    12517       -2     
- Misses       3156     3157       +1     
- Partials      952      953       +1
Impacted Files Coverage Δ
ui/node/attributes.go 60.86% <ø> (ø)
persistence/sql/persister_courier.go 86.76% <0.00%> (-2.95%) ⬇️

Help us with your feedback. Take ten seconds to tell us how you rate us.

@aeneasr aeneasr merged commit 8800085 into master Jul 26, 2022
@aeneasr aeneasr deleted the fix-enum-rust branch July 26, 2022 10:46
peturgeorgievv pushed a commit to senteca/kratos-fork that referenced this pull request Jun 30, 2023
@aeneasr @ory-bot
fix(sdk): rust compile issue with required enum (ory#2619)
e9d5491 
Co-authored-by: ory-bot <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@zepatrik zepatrik Awaiting requested review from zepatrik

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@aeneasr @ory-bot