Thanks to visit codestin.com
Credit goes to github.com

Skip to content

feat: Oauth2 integration #2804

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 37 commits into from
Oct 26, 2022
Merged

feat: Oauth2 integration #2804

merged 37 commits into from
Oct 26, 2022

Conversation

@aeneasr
Copy link
Member

@aeneasr aeneasr commented Oct 14, 2022

Related issue(s)

Checklist

  • I have read the contributing guidelines.
  • I have referenced an issue containing the design document if my change
    introduces a new feature.
  • I am following the
    contributing code guidelines.
  • I have read the security policy.
  • I confirm that this pull request does not address a security
    vulnerability. If this pull request addresses a security vulnerability, I
    confirm that I got the approval (please contact
    [email protected]) from the maintainers to push
    the changes.
  • I have added tests that prove my fix is effective or that my feature
    works.
  • I have added or changed the documentation.

Further Comments

@aeneasr aeneasr force-pushed the oauth2-integration-review branch from 4b05151 to ef346dd Compare October 14, 2022 07:27
@aeneasr aeneasr marked this pull request as ready for review October 15, 2022 08:54
@aeneasr aeneasr requested a review from zepatrik as a code owner October 15, 2022 08:54
@aeneasr aeneasr force-pushed the oauth2-integration-review branch from c670d38 to 7263310 Compare October 17, 2022 08:18
grantzvolsky and others added 26 commits October 23, 2022 00:44
@grantzvolsky @aeneasr
feat: integration with Hydra
380c6a7
@grantzvolsky @aeneasr
test(kratos-hydra): fix mysql migration; fix e2e test
27d905e
@grantzvolsky @aeneasr
chore: format
7127580
@grantzvolsky @aeneasr
code review: fix migration names
5668ce4
@grantzvolsky @aeneasr
test(e2e): fix process cleanup; remove broken cypress option
54ec068 
This commit removes the --e2e cypress option because it is broken in the
current release. There is an unreleased fix[1], so we may re-add it later, but
it isn't necessary because --e2e is the default.

[1]: cypress-io/cypress#22829
@grantzvolsky @aeneasr
code review(kratos-hydra): pass remember, remember_for, and amr to Hydra
162d1b4 
When using Kratos with Hydra as an OIDC IDP, the Kratos options

* session.cookie.persistent and
* session.lifespan

now also apply to third party login.
@grantzvolsky @aeneasr
autogen(openapi): regenerate swagger spec and internal client
61df33e
@aeneasr
fix: remove debug info from error and trace errors
79672b2
@grantzvolsky @aeneasr
code review(oidc-provider): respect login skip attribute
db51cba
@grantzvolsky @aeneasr
chore: format
19dae77
@grantzvolsky @aeneasr
test: kratos-hydra session subject mismatch
de7c411
@grantzvolsky @aeneasr
fix: require aal2 when check fails
85466a8
@grantzvolsky @aeneasr
test: ensure login_challenge is passed to redirect_to
bc01af4
@grantzvolsky @aeneasr
chore: update x/sys for M1
bf94750
@grantzvolsky @aeneasr
code review: trigger logout if signed-in user registers in OP flow
68be1d9
@grantzvolsky @aeneasr
code review: cleanup
8f26df2
@grantzvolsky @aeneasr
code review: simplify login handler logic; add fake Hydra tests
ee1983b
@grantzvolsky @aeneasr
chore: fix linter errors
7adcd54
@grantzvolsky @aeneasr
chore: resolve merge conflicts
c6608a5
@grantzvolsky @aeneasr
chore: resolve merge conflicts
e8a39a9
@grantzvolsky @aeneasr
chore: update deprecated gh action
316c692
@grantzvolsky @aeneasr
fix(ci): allow private ip ranges in Hydra e2e tests
1038563
@grantzvolsky @aeneasr
fix(ci): allow private ip ranges in Hydra e2e tests
7a04668
@aeneasr
refactor: rename config parameter
6c35db0
@aeneasr
chore: adjust naming
ddbce5e
@aeneasr
chore: improve function signature
be0d66a
@aeneasr aeneasr force-pushed the oauth2-integration-review branch from 7263310 to a702195 Compare October 22, 2022 22:44
@aeneasr aeneasr force-pushed the oauth2-integration-review branch from 8f91996 to 0947832 Compare October 24, 2022 08:56
@aeneasr aeneasr force-pushed the oauth2-integration-review branch from 9e59c05 to 5f0ac03 Compare October 24, 2022 14:00
@aeneasr aeneasr merged commit 7c6eb2a into master Oct 26, 2022
@aeneasr aeneasr deleted the oauth2-integration-review branch October 26, 2022 07:55
@mitar mitar mentioned this pull request Oct 26, 2022
Closed
7 tasks
peturgeorgievv pushed a commit to senteca/kratos-fork that referenced this pull request Jun 30, 2023
@aeneasr
feat: OAuth2 integration (ory#2804)
5861074 
This feature allows Ory Kratos to act as a login provider for Ory Hydra using the `oauth2_provider.url` configuration value.

Closes ory#273
Closes ory#2293
See ory/kratos-selfservice-ui-node#50
See ory/kratos-selfservice-ui-node#68
See ory/kratos-selfservice-ui-node#108
See ory/kratos-selfservice-ui-node#111
See ory/kratos-selfservice-ui-node#149
See ory/kratos-selfservice-ui-node#170
See ory/kratos-selfservice-ui-node#198
See ory/kratos-selfservice-ui-node#207
@eest eest mentioned this pull request Aug 9, 2023
Closed
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@zepatrik zepatrik Awaiting requested review from zepatrik

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@aeneasr @grantzvolsky