Thanks to visit codestin.com
Credit goes to github.com

Skip to content

fix: wrong config key in admin recovery documentation #2815

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 26, 2022
Merged

fix: wrong config key in admin recovery documentation #2815

merged 1 commit into from
Oct 26, 2022

Conversation

@jonas-jonas
Copy link
Member

@jonas-jonas jonas-jonas commented Oct 17, 2022

Related issue(s)

Closes #2579

Checklist

  • I have read the contributing guidelines.
  • I have referenced an issue containing the design document if my change
    introduces a new feature.
  • I am following the
    contributing code guidelines.
  • I have read the security policy.
  • I confirm that this pull request does not address a security
    vulnerability. If this pull request addresses a security vulnerability, I
    confirm that I got the approval (please contact
    [email protected]) from the maintainers to push
    the changes.
  • I have added tests that prove my fix is effective or that my feature
    works.
  • I have added or changed the documentation.

Further Comments

@codecov
Copy link

codecov bot commented Oct 17, 2022

Codecov Report

Merging #2815 (820bacf) into master (4682afa) will increase coverage by 0.03%.
The diff coverage is n/a.

❗ Current head 820bacf differs from pull request most recent head a06949d. Consider uploading reports for the commit a06949d to get more accurate results

@@            Coverage Diff             @@
##           master    #2815      +/-   ##
==========================================
+ Coverage   75.88%   75.92%   +0.03%     
==========================================
  Files         302      302              
  Lines       17816    17816              
==========================================
+ Hits        13520    13526       +6     
+ Misses       3259     3256       -3     
+ Partials     1037     1034       -3
Impacted Files Coverage Δ
selfservice/strategy/code/strategy_recovery.go 69.69% <ø> (ø)
selfservice/strategy/link/strategy_recovery.go 62.71% <ø> (ø)
persistence/sql/persister.go 74.41% <0.00%> (+1.55%) ⬆️
persistence/sql/persister_courier.go 86.86% <0.00%> (+4.04%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@aeneasr aeneasr merged commit 154b61b into master Oct 26, 2022
@aeneasr aeneasr deleted the fix/correctConfigValuesRecovery branch October 26, 2022 09:22
peturgeorgievv pushed a commit to senteca/kratos-fork that referenced this pull request Jun 30, 2023
@jonas-jonas
fix: wrong config key in admin recovery documentation (ory#2815)
cbef7ad
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@aeneasr aeneasr aeneasr approved these changes

@zepatrik zepatrik Awaiting requested review from zepatrik

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Documentation problem: recovery link lifespan

3 participants

@jonas-jonas @aeneasr