Thanks to visit codestin.com
Credit goes to github.com

Skip to content

feat: remove duplicate queries from whoami calls #2995

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 15 commits into from
Jan 10, 2023
Merged

feat: remove duplicate queries from whoami calls #2995

merged 15 commits into from
Jan 10, 2023

Conversation

@aeneasr
Copy link
Member

@aeneasr aeneasr commented Jan 2, 2023

Closes #2402

Related issue(s)

Checklist

  • I have read the contributing guidelines.
  • I have referenced an issue containing the design document if my change
    introduces a new feature.
  • I am following the
    contributing code guidelines.
  • I have read the security policy.
  • I confirm that this pull request does not address a security
    vulnerability. If this pull request addresses a security vulnerability, I
    confirm that I got the approval (please contact
    [email protected]) from the maintainers to push
    the changes.
  • I have added tests that prove my fix is effective or that my feature
    works.
  • I have added or changed the documentation.

Further Comments

@aeneasr aeneasr force-pushed the improve-whoami-close-2402 branch 2 times, most recently from 1f6ef33 to 887a084 Compare January 3, 2023 07:23
@aeneasr aeneasr force-pushed the improve-whoami-close-2402 branch from 887a084 to 7a229aa Compare January 3, 2023 07:24
@aeneasr aeneasr marked this pull request as ready for review January 3, 2023 08:34
@aeneasr aeneasr requested a review from zepatrik as a code owner January 3, 2023 08:34
@aeneasr aeneasr self-assigned this Jan 3, 2023
github-advanced-security[bot]
github-advanced-security bot found potential problems Jan 3, 2023
View reviewed changes
@aeneasr aeneasr force-pushed the improve-whoami-close-2402 branch from 79309dc to f021cab Compare January 3, 2023 09:44
kelkarajay
kelkarajay suggested changes Jan 3, 2023
View reviewed changes
kelkarajay
kelkarajay reviewed Jan 3, 2023
View reviewed changes
@aeneasr aeneasr force-pushed the improve-whoami-close-2402 branch 3 times, most recently from 540781c to 5ae2be3 Compare January 4, 2023 10:59
@aeneasr aeneasr force-pushed the improve-whoami-close-2402 branch from 5ae2be3 to f99cac9 Compare January 4, 2023 12:35
@aeneasr aeneasr force-pushed the improve-whoami-close-2402 branch from f99cac9 to 73f8313 Compare January 4, 2023 12:39
@aeneasr aeneasr force-pushed the improve-whoami-close-2402 branch from 9411175 to 14fbf1c Compare January 5, 2023 10:40
@aeneasr aeneasr force-pushed the improve-whoami-close-2402 branch from 14fbf1c to 4c6de1a Compare January 5, 2023 10:50
@aeneasr aeneasr force-pushed the improve-whoami-close-2402 branch from 7bfcc83 to c696602 Compare January 5, 2023 12:18
@aeneasr aeneasr force-pushed the improve-whoami-close-2402 branch from b6c2c1b to 7c1ba22 Compare January 5, 2023 12:44
@codecov
Copy link

codecov bot commented Jan 5, 2023

Codecov Report

Merging #2995 (8d26a9e) into master (04d0280) will increase coverage by 0.31%.
The diff coverage is 91.55%.

❗ Current head 8d26a9e differs from pull request most recent head 7c1ba22. Consider uploading reports for the commit 7c1ba22 to get more accurate results

@@            Coverage Diff             @@
##           master    #2995      +/-   ##
==========================================
+ Coverage   76.18%   76.49%   +0.31%     
==========================================
  Files         309      308       -1     
  Lines       19085    19177      +92     
==========================================
+ Hits        14539    14669     +130     
+ Misses       3422     3404      -18     
+ Partials     1124     1104      -20
Impacted Files Coverage Δ
cipher/aes.go 100.00% <ø> (ø)
cipher/chacha20.go 80.55% <ø> (ø)
cipher/noop.go 100.00% <ø> (ø)
cmd/cleanup/root.go 100.00% <ø> (ø)
cmd/cleanup/sql.go 96.00% <ø> (ø)
cmd/cliclient/cleanup.go 27.27% <ø> (ø)
cmd/cliclient/client.go 35.71% <ø> (ø)
cmd/cliclient/migrate.go 29.57% <ø> (ø)
cmd/clidoc/main.go 66.34% <ø> (ø)
cmd/courier/root.go 100.00% <ø> (ø)
... and 138 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@alnr
Copy link
Contributor

alnr commented Jan 9, 2023

LGTM

@aeneasr aeneasr merged commit b50a222 into master Jan 10, 2023
@aeneasr aeneasr deleted the improve-whoami-close-2402 branch January 10, 2023 13:35
CNLHC pushed a commit to seekthought/kratos that referenced this pull request May 16, 2023
@aeneasr @CNLHC
feat: remove duplicate queries from whoami calls (ory#2995)
a90f465 
Introduces an expand API to the identity persister which greatly improves whoami performance.

Closes ory#2402
peturgeorgievv pushed a commit to senteca/kratos-fork that referenced this pull request Jun 30, 2023
@aeneasr
feat: remove duplicate queries from whoami calls (ory#2995)
f7d8b11 
Introduces an expand API to the identity persister which greatly improves whoami performance.

Closes ory#2402
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@zepatrik zepatrik Awaiting requested review from zepatrik

1 more reviewer

@kelkarajay kelkarajay kelkarajay requested changes

Reviewers whose approvals may not affect merge requirements

Assignees

@aeneasr aeneasr

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

whoami performance

3 participants

@aeneasr @alnr @kelkarajay