Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Conversation

@vineetbansal
Copy link
Contributor

Experimental branch that uses qdldl as a git submodule. I'll tweak a branch on the python wrappers to see if the wrappers can be built against this branch correctly.

@coveralls
Copy link

coveralls commented Sep 24, 2025

Pull Request Test Coverage Report for Build 18009176816

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.2%) to 91.629%

Totals Coverage Status
Change from base Build 17592687003: 0.2%
Covered Lines: 3831
Relevant Lines: 4181

💛 - Coveralls

@vineetbansal
Copy link
Contributor Author

@imciner2 - for the python wrapper, PR 186 seems to be working fine, with the tweak:

cmake_minimum_required(VERSION 3.16...3.26)
...
FetchContent_Declare(
  osqp
  GIT_REPOSITORY https://github.com/osqp/osqp.git
  GIT_SHALLOW ON
  GIT_TAG vb/git_submods
  GIT_SUBMODULES ext/qdldl
)

3.16 is to get the new behavior as per on an empty GIT_SUBMODULES as per https://cmake.org/cmake/help/latest/policy/CMP0097.html#policy:CMP0097, though we're explicitly specifying the submodule we want.

If a similar pattern can be made to work with the rest of the wrappers, maybe we merge this, tag it, and update all the wrappers?

Quality-of-life improvements on qdldl.cmake

Co-authored-by: Ian McInerney <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants