feat: display spinning progress #417
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
daejunpark
commented
Nov 19, 2024
Collaborator
Author
|
@karmacoma-eth now ready to review. |
daejunpark
commented
Nov 20, 2024
daejunpark
commented
Nov 20, 2024
Merged
0xkarmacoma
approved these changes
Dec 3, 2024
Collaborator
0xkarmacoma
left a comment
There was a problem hiding this comment.
minor comments but overall love seeing the live updates during a long run 👌
src/halmos/config.py
Outdated
| short="st", | ||
| ) | ||
|
|
||
| no_pulse: bool = arg( |
Collaborator
There was a problem hiding this comment.
I'm not a big fan of the --no-XYZ flag format. If it's easy to support with our config format, I would prefer a single configurable flag with an explicit value like this:
--pulse=true--pulse=false--pulseis an alias for--pulse=true
Collaborator
Author
There was a problem hiding this comment.
agree. leave as future work.
Co-authored-by: karmacoma <[email protected]>
Co-authored-by: karmacoma <[email protected]>
Co-authored-by: karmacoma <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
display a spinning progress for path exploration and assertion solving: