fix: check infeasible errors #445
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
daejunpark
commented
Jan 21, 2025
| if args.print_blocked_states: | ||
| traces[idx] = f"{hexify(ex.path)}\n{rendered_trace(ex.context)}" | ||
| debug(f"Potential error path (id: {idx+1})") | ||
| res, _, _ = solve(ex.path.to_smt2(args), args) |
Collaborator
Author
There was a problem hiding this comment.
performance concern: this may block the path exploration thread.
an alternative approach is to add this into the assertion-solving thread pool, but it requires further code refactoring. not sure it's worth it at this point.
Collaborator
There was a problem hiding this comment.
yeah that would be a big change, and would break some assumptions in the assertion-solving thread pool (sincewe collect/triage/print counterexamples). If necessary we could add a separation branch-solving thread pool, but I don't think it would interact well with the z3 context push/pop mechanism (can't really keep exploring another branch until this one is done)
0xkarmacoma
approved these changes
Jan 21, 2025
Collaborator
0xkarmacoma
left a comment
There was a problem hiding this comment.
good trade-off IMO 👌
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
infeasible (halmos) errors may be reported if the branching timeout is not enough to prune infeasible error paths during path exploration. this pr adds checks to ensure error conditions are feasible.