Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Conversation

BowDown097
Copy link
Contributor

No description provided.

@a1ext
Copy link
Owner

a1ext commented Aug 11, 2024

Hi @BowDown097,
Thanks for your contribution, I appreciate that :)

I think we should keep backward compatibility with older that 9.0 versions too.

I would suggest to add add SDK version checks like I did in the following line:

return (idaapi.get_dword if idaapi.IDA_SDK_VERSION >= 700 else idaapi.get_long)(ea)

but in your case, the constant should be adjusted 900 like:

(new_api if idaapi.IDA_SDK_VERSION >= 900 else old_api)(arg0, arg1, etc)

Would you be so kind to adjust it yourself? Otherwise all is ok, I will do this myself.

Thanks 👍

@BowDown097
Copy link
Contributor Author

That should do it.

@a1ext
Copy link
Owner

a1ext commented Sep 5, 2024

Thanks for support @BowDown097! Merging it

@a1ext a1ext merged commit 2ea88f0 into a1ext:master Sep 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants